[MachineInstrBuilder]: Add BuildMIAfter variant #151607
Open
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id60cc08a836bcc514b838e0782ddb9948dedf857
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Change-Id: I14c346a3e900c2994a685d849637ce01854c63d3
arsenm
reviewed
Jul 31, 2025
| return MachineInstrBuilder(MF, MI) | ||
| .setPCSections(MIMD.getPCSections()) | ||
| .setMMRAMetadata(MIMD.getMMRAMetadata()); | ||
| } |
Contributor
There was a problem hiding this comment.
Can you add an insertAfter to MachineInstrBuilder instead? e.g. BuildMI(...).insertAfter(I)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see any version that had the
insertAfterfunctionality.This makes life easier for clients who want to
insertAftera given MI. Otherwise, they will need to create an ad-hoc implementation or do manipulate the iterators to work with the insert before versions.