Skip to content

[mlir][NFC] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefiningOp()) #150428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

[mlir][NFC] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefiningOp()) #150428

merged 1 commit into from
Jul 25, 2025

Conversation

CoTinker
Copy link
Contributor

@CoTinker CoTinker commented Jul 24, 2025 •
edited
Loading

This PR uses val.getDefiningOp<OpTy>() to replace dyn_cast<OpTy>(val.getDefiningOp()) , dyn_cast_or_null<OpTy>(val.getDefiningOp()) and dyn_cast_if_present<OpTy>(val.getDefiningOp()).

@kuhar
Copy link
Member

kuhar commented Jul 24, 2025

BTW, we could do a similar cleanup for dyn_cast<T>(typeConverter->convertType(foo)) --> typeConverter->convertType<T>(foo)

@CoTinker
Copy link
Contributor Author

BTW, we could do a similar cleanup for dyn_cast<T>(typeConverter->convertType(foo)) --> typeConverter->convertType<T>(foo)

Great, I'm glad to do that in another PR. Thanks for your advice.

@CoTinker
[mlir][NFC] Use getDefiningOp<OpTy>() instead of `dyn_cast<OpTy>(ge…
766bb8a 
…tDefiningOp())`

This PR uses `val.getDefiningOp<OpTy>()` to replace `dyn_cast<OpTy>(val.getDefiningOp())`
, `dyn_cast_or_null<OpTy>(val.getDefiningOp())` and `dyn_cast_if_present<OpTy>(val.getDefiningOp())`.
@CoTinker CoTinker force-pushed the dyn_cast_defining branch from df7a99f to 766bb8a Compare July 24, 2025 14:40
rengolin
rengolin approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@rengolin rengolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!

joker-eph
joker-eph approved these changes Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

It would be great to have a clang-tidy check for this.

@CoTinker CoTinker merged commit f047b73 into llvm:main Jul 25, 2025
9 checks passed
@CoTinker CoTinker deleted the dyn_cast_defining branch July 25, 2025 02:35
searlmc1 pushed a commit to ROCm/llvm-project that referenced this pull request Jul 25, 2025
@ronlieb
Revert "[mlir][NFC] Use getDefiningOp<OpTy>() instead of `dyn_cast<…
e0e489b 
…OpTy>(getDefiningOp())` (llvm#150428)"

seems to break
declare-target-and-explicit-map
declare-target-and-implicit-and-explicit-map
declare-target-link-1
declare-target-link-2
declare-target-link-3

This reverts commit f047b73.
xlauko added a commit to llvm/clangir that referenced this pull request Jul 27, 2025
@xlauko
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
a2dd67b 
…Op()) (NFC)

This applies similar changes to llvm/llvm-project#150428
@xlauko xlauko mentioned this pull request Jul 27, 2025
Merged
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Jul 28, 2025
@CoTinker @mahesh-attarde
[mlir][NFC] Use getDefiningOp<OpTy>() instead of `dyn_cast<OpTy>(ge…
cb06728 
…tDefiningOp())` (llvm#150428)

This PR uses `val.getDefiningOp<OpTy>()` to replace `dyn_cast<OpTy>(val.getDefiningOp())` , `dyn_cast_or_null<OpTy>(val.getDefiningOp())` and `dyn_cast_if_present<OpTy>(val.getDefiningOp())`.
xlauko added a commit to llvm/clangir that referenced this pull request Jul 29, 2025
@xlauko
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
fb0bac1 
…Op()) (NFC)

This applies similar changes to llvm/llvm-project#150428
xlauko added a commit to llvm/clangir that referenced this pull request Jul 29, 2025
@xlauko
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
5735086 
…Op()) (NFC)

This applies similar changes to llvm/llvm-project#150428
xlauko added a commit to llvm/clangir that referenced this pull request Jul 29, 2025
@xlauko
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
d45823a 
…Op()) (NFC) (#1765)

This applies similar changes to llvm/llvm-project#150428
xlauko added a commit that referenced this pull request Jul 29, 2025
@xlauko
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
dc74a82 
…Op()) (NFC)

This applies similar changes to #150428
@xlauko xlauko mentioned this pull request Jul 29, 2025
Merged
xlauko added a commit that referenced this pull request Aug 2, 2025
@xlauko
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
320cabc 
…Op()) (NFC)

This applies similar changes to #150428
xlauko added a commit that referenced this pull request Aug 2, 2025
@xlauko
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
44500ae 
…Op()) (NFC) (#151217)

This applies similar changes to #150428
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Aug 2, 2025
@xlauko @github-actions
Automerge: [CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(…
3214b3f 
…getDefiningOp()) (NFC) (#151217)

This applies similar changes to llvm/llvm-project#150428
lanza pushed a commit to lanza/llvm-project that referenced this pull request Aug 11, 2025
@xlauko @lanza
[CIR] Use getDefiningOp<OpTy>() instead of dyn_cast<OpTy>(getDefining…
6c29c0c 
…Op()) (NFC) (llvm#1765)

This applies similar changes to llvm#150428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rengolin rengolin rengolin approved these changes

@joker-eph joker-eph joker-eph approved these changes

@kuhar kuhar kuhar approved these changes

@kazutakahirata kazutakahirata Awaiting requested review from kazutakahirata

@aartbik aartbik Awaiting requested review from aartbik aartbik is a code owner

@PeimingLiu PeimingLiu Awaiting requested review from PeimingLiu PeimingLiu is a code owner

@yinying-lisa-li yinying-lisa-li Awaiting requested review from yinying-lisa-li yinying-lisa-li is a code owner

@matthias-springer matthias-springer Awaiting requested review from matthias-springer matthias-springer is a code owner

@ftynse ftynse Awaiting requested review from ftynse ftynse is a code owner

@nicolasvasilache nicolasvasilache Awaiting requested review from nicolasvasilache nicolasvasilache is a code owner

@banach-space banach-space Awaiting requested review from banach-space banach-space is a code owner

@dcaballe dcaballe Awaiting requested review from dcaballe dcaballe is a code owner

@Groverkss Groverkss Awaiting requested review from Groverkss Groverkss is a code owner

Assignees

No one assigned

Labels

flang:openmp mlir:affine mlir:arith mlir:emitc mlir:linalg mlir:llvm mlir:neon mlir:openacc mlir:openmp mlir:scf mlir:sparse Sparse compiler in MLIR mlir:sve mlir:tosa mlir:vector mlir:vectorops mlir openacc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CoTinker @llvmbot @kuhar @rengolin @joker-eph