- 
                Notifications
    
You must be signed in to change notification settings  - Fork 15.1k
 
[AMDGPU] Reenable tanh real-true16 run line. NFC. #149411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            rampitec
  merged 2 commits into
  main
from
users/rampitec/07-17-_amdgpu_reenable_tanh_real-true16_run_line._nfc
  
      
      
   
  Jul 17, 2025 
      
    
                
     Merged
            
            [AMDGPU] Reenable tanh real-true16 run line. NFC. #149411
                    rampitec
  merged 2 commits into
  main
from
users/rampitec/07-17-_amdgpu_reenable_tanh_real-true16_run_line._nfc
  
      
      
   
  Jul 17, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          
 This stack of pull requests is managed by Graphite. Learn more about stacking.  | 
    
| 
          
 @llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) ChangesFull diff: https://github.com/llvm/llvm-project/pull/149411.diff 1 Files Affected: 
 diff --git a/llvm/test/CodeGen/AMDGPU/llvm.amdgcn.tanh.ll b/llvm/test/CodeGen/AMDGPU/llvm.amdgcn.tanh.ll
index 91a2a0b651132..61e36f5b84923 100644
--- a/llvm/test/CodeGen/AMDGPU/llvm.amdgcn.tanh.ll
+++ b/llvm/test/CodeGen/AMDGPU/llvm.amdgcn.tanh.ll
@@ -1,5 +1,5 @@
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
-; xUN: llc -global-isel=0 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 -mattr=+real-true16 %s -o - | FileCheck -check-prefix=SDAG-REAL16 %s
+; RUN: llc -global-isel=0 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 -mattr=+real-true16 %s -o - | FileCheck -check-prefix=SDAG-REAL16 %s
 ; RUN: llc -global-isel=0 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 -mattr=-real-true16 %s -o - | FileCheck -check-prefix=SDAG-FAKE16 %s
 ; xUN: llc -global-isel=1 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 -mattr=+real-true16 %s -o - | FileCheck -check-prefix=GISEL-REAL16 %s
 ; xUN: llc -global-isel=1 -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 -mattr=-real-true16 %s -o - | FileCheck -check-prefix=GISEL-FAKE16 %s
 | 
    
| 
           @shiltian if you have more cases like that it shall be resolved after the parent change is landed. s16 stores are fixed.  | 
    
              
                    changpeng
  
              
              approved these changes
              
                  
                    Jul 17, 2025 
                  
              
              
            
            
              
                    shiltian
  
              
              reviewed
              
                  
                    Jul 17, 2025 
                  
              
              
            
            
71819a9    to
    0bf6f72      
    Compare
  
    d907c98    to
    f3b85f5      
    Compare
  
    
              
                    shiltian
  
              
              approved these changes
              
                  
                    Jul 17, 2025 
                  
              
              
            
            
    
          Base automatically changed from
    
      users/rampitec/07-17-_amdgpu_more_flatgvs_gfx1250_atomic_patterns
     to
    
      main
    
    July 17, 2025 23:11     
    
  This was referenced Jul 23, 2025 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
No description provided.