Skip to content

[DWARFLinker] Use different addresses to distinguish invalid DW_AT_LLVM_stmt_sequence offset #149376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025

Conversation

DataCorrupted
Copy link
Member

@DataCorrupted DataCorrupted commented Jul 17, 2025

It'd be helpful (especially when llvm-dwarfdump ... | grep <invalid_address>) to separate two different invalid reasons for debugging.

@DataCorrupted DataCorrupted requested review from alx32 and removed request for JDevlieghere July 17, 2025 18:27
@DataCorrupted DataCorrupted self-assigned this Jul 17, 2025
@ellishg
Copy link
Contributor

ellishg commented Jul 17, 2025

Could we add a test?

@DataCorrupted
Copy link
Member Author

The whole debugging process would be much easier if I have a min repro when either is generated. So no at the moment. By the time I can add a test, I would be close to resolving this :\

@DataCorrupted DataCorrupted merged commit b0c6148 into llvm:main Jul 17, 2025
9 checks passed
@JDevlieghere
Copy link
Member

@DataCorrupted Please don't remove reviewers when they get added automatically. It defeats the purpose of the person creating those rules.

Regarding the test, I understand you're making the change to debug an issue that you don't have a reproducer for, but the the case where the origin offset is missing seems like a situation for which you could hand-craft a test case?

@DataCorrupted
Copy link
Member Author

@JDevlieghere Thanks for the advice.

Yes I could add a case where the original offset is missing, but that's not the bug I'm working on. The bug I have here is that the object file contains valid offsets, but that offset went missing after linking. I'm still chasing when/where that offset went missing. I'll add a test when I can create a repro for that, and include you as the reviewer.

DataCorrupted added a commit to DataCorrupted/llvm-project that referenced this pull request Jul 17, 2025
…DW_AT_LLVM_stmt_sequence offset (llvm#149376)"

This reverts commit b0c6148.
DataCorrupted added a commit that referenced this pull request Jul 18, 2025
#149422)

…DW_AT_LLVM_stmt_sequence offset (#149376)"

This reverts commit b0c6148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants