Skip to content

[Clang] Fix clang crash for fopenmp statement(parallel for) inside lambda function #146772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+425 −0
Open

[Clang] Fix clang crash for fopenmp statement(parallel for) inside lambda function #146772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions clang/lib/CodeGen/CGStmtOpenMP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2332,6 +2332,12 @@ void CodeGenFunction::EmitOMPPrivateLoopCounters(
for (const Expr *E : S.counters()) {
const auto *VD = cast<VarDecl>(cast<DeclRefExpr>(E)->getDecl());
const auto *PrivateVD = cast<VarDecl>(cast<DeclRefExpr>(*I)->getDecl());
// Privatize original counter variable (e.g., __beginN, __endN, __rangeN)
if (!LocalDeclMap.count(VD)) {
Address Addr = CreateMemTemp(VD->getType(), VD->getName());
LocalDeclMap.insert({VD, Addr});
(void)LoopScope.addPrivate(VD, Addr);
}
Comment on lines +2335 to +2340
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is too broad. Why the original variables are not captured and privatized? Looks like we're missing some analysis

// Emit var without initialization.
AutoVarEmission VarEmission = EmitAutoVarAlloca(*PrivateVD);
EmitAutoVarCleanups(VarEmission);
Expand Down
Loading
Loading