[VPlan] Remove redundant debug location setting in VPInterleaveRecipe::execute. nfc

[Mel-Chen]

Remove it since we already set debug loc in VPBasicBlock::executeRecipes.

[llvmbot]

@llvm/pr-subscribers-vectorizers

@llvm/pr-subscribers-llvm-transforms

Author: Mel Chen (Mel-Chen)

Changes

Remove it since we already set debug loc in VPBasicBlock::executeRecipes.

---

Full diff: https://github.com/llvm/llvm-project/pull/146670.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp (-4)

diff --git a/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp b/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp
index 24f2d6a83c5e4..1375193181fbc 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp
@@ -3425,10 +3425,6 @@ void VPInterleaveRecipe::execute(VPTransformState &State) {
 
   VPValue *Addr = getAddr();
   Value *ResAddr = State.get(Addr, VPLane(0));
-  if (auto *I = dyn_cast<Instruction>(ResAddr))
-    State.setDebugLocFrom(I->getDebugLoc());
-
-  State.setDebugLocFrom(getDebugLoc());
   Value *PoisonVec = PoisonValue::get(VecTy);
 
   auto CreateGroupMask = [&BlockInMask, &State,

[lukel97]

LGTM

[lukel97]

Just making a note here, is this strictly NFC? VPBasicBlock::executeRecipes takes the debug location always from the recipe but this seems to copy it from the address. I don't think this is important

[Mel-Chen]

This patch didn't actually touch any debug locs.
I just realized it was probably #144864 that modified the address debug loc. Perhaps we could revert to using the debug location from Addr, if necessary.

[fhahn]

LGTM thanks. Should respect the recipe debug loc and most adress computations are modeled separately