Skip to content

WIP: fix assert in hasInitWithSideEffects #146468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −9
Open

WIP: fix assert in hasInitWithSideEffects #146468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions clang/lib/AST/Decl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2444,20 +2444,14 @@ bool VarDecl::hasInitWithSideEffects() const {
if (!hasInit())
return false;

// Check if we can get the initializer without deserializing
const Expr *E = nullptr;
// Check if we can get the initializer directly without an external source
if (auto *S = dyn_cast<Stmt *>(Init)) {
E = cast<Expr>(S);
} else {
E = cast_or_null<Expr>(getEvaluatedStmt()->Value.getWithoutDeserializing());
}

if (E)
const Expr *E = cast<Expr>(S);
return E->HasSideEffects(getASTContext()) &&
// We can get a value-dependent initializer during error recovery.
(E->isValueDependent() || !evaluateValue());
}

assert(getEvaluatedStmt()->Value.isOffset());
// ASTReader tracks this without having to deserialize the initializer
if (auto Source = getASTContext().getExternalSource())
return Source->hasInitializerWithSideEffects(this);
Expand Down
Loading