Skip to content

[Flang] Force lowering to Complex for AMDGPU #144927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

[Flang] Force lowering to Complex for AMDGPU #144927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8733392
[Flang] Force lowering to Complex for AMDGPU
TIFitis Jun 19, 2025
17b5ac2
Add test
TIFitis Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions flang/lib/Optimizer/Builder/IntrinsicCall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,8 +1228,11 @@ mlir::Value genComplexMathOp(fir::FirOpBuilder &builder, mlir::Location loc,
llvm::StringRef mathLibFuncName = mathOp.runtimeFunc;
if (!mathLibFuncName.empty()) {
// If we enabled MLIR complex or can use approximate operations, we should
// NOT use libm.
if (!forceMlirComplex && !canUseApprox) {
// NOT use libm. Avoid libm when targeting AMDGPU as those symbols are not
// available on the device and we rely on MLIR complex operations to
// later map to OCML calls.
bool isAMDGPU = fir::getTargetTriple(builder.getModule()).isAMDGCN();
if (!forceMlirComplex && !canUseApprox && !isAMDGPU) {
result = genLibCall(builder, loc, mathOp, mathLibFuncType, args);
LLVM_DEBUG(result.dump(); llvm::dbgs() << "\n");
return result;
Expand Down
21 changes: 21 additions & 0 deletions flang/test/Lower/amdgcn-complex.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
! REQUIRES: amdgpu-registered-target
! RUN: %flang_fc1 -triple amdgcn-amd-amdhsa -emit-fir -flang-deprecated-no-hlfir %s -o - | FileCheck %s

subroutine cabsf_test(a, b)
complex :: a
real :: b
b = abs(a)
end subroutine

! CHECK-LABEL: func @_QPcabsf_test(
! CHECK: complex.abs
! CHECK-NOT: fir.call @cabsf

subroutine cexpf_test(a, b)
complex :: a, b
b = exp(a)
end subroutine

! CHECK-LABEL: func @_QPcexpf_test(
! CHECK: complex.exp
! CHECK-NOT: fir.call @cexpf
Loading