[libc][obvious] Changed incorrect type #143780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changing mbstate_t to mbstate we forgot to change the character_converter files to reflect it.
|
@llvm/pr-subscribers-libc Author: None (sribee8) ChangesAfter changing mbstate_t to mbstate we forgot to change the character_converter files to reflect it. Full diff: https://github.com/llvm/llvm-project/pull/143780.diff 2 Files Affected:
diff --git a/libc/src/__support/wchar/character_converter.cpp b/libc/src/__support/wchar/character_converter.cpp
index 0afc2a6f59e64..3cdb8ca83b7f0 100644
--- a/libc/src/__support/wchar/character_converter.cpp
+++ b/libc/src/__support/wchar/character_converter.cpp
@@ -16,7 +16,7 @@
namespace LIBC_NAMESPACE_DECL {
namespace internal {
-CharacterConverter::CharacterConverter(mbstate_t *mbstate) { state = mbstate; }
+CharacterConverter::CharacterConverter(mbstate *mbstate) { state = mbstate; }
bool CharacterConverter::isComplete() {}
diff --git a/libc/src/__support/wchar/character_converter.h b/libc/src/__support/wchar/character_converter.h
index a6bac43805376..d0602d2defe22 100644
--- a/libc/src/__support/wchar/character_converter.h
+++ b/libc/src/__support/wchar/character_converter.h
@@ -19,10 +19,10 @@ namespace internal {
class CharacterConverter {
private:
- mbstate_t *state;
+ mbstate *state;
public:
- CharacterConverter(mbstate_t *mbstate);
+ CharacterConverter(mbstate *mbstate);
bool isComplete();
|
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
After changing mbstate_t to mbstate we forgot to change the character_converter files to reflect it. Co-authored-by: Sriya Pratipati <sriyap@google.com>
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
After changing mbstate_t to mbstate we forgot to change the character_converter files to reflect it. Co-authored-by: Sriya Pratipati <sriyap@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changing mbstate_t to mbstate we forgot to change the character_converter files to reflect it.