[llvm] annotate interfaces in llvm/SandboxIR for DLL export #142863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This patch is one in a series of code-mods that annotate LLVM’s public interface for export. This patch annotates the
llvm/SandboxIR
library. These annotations currently have no meaningful impact on the LLVM build; however, they are a prerequisite to support an LLVM Windows DLL (shared library) build.Background
This effort is tracked in #109483. Additional context is provided in this discourse, and documentation for
LLVM_ABI
and related annotations is found in the LLVM repo here.The bulk of these changes were generated automatically using the Interface Definition Scanner (IDS) tool, followed formatting with
git clang-format
.The following manual adjustments were also applied after running IDS on Linux:
#if defined(_MSC_VER) && !defined(__clang__)
guard inConstant.h
that was already used for the corresponding declarations inConstant.cpp
.#include "llvm/SandboxIR/Value.h"
inTracker.h
so that the symbol is available for exported templates in this file. These templates get fully instantiated on DLL export, so they require the full definition ofValue
.GlobalWithNodeAPI
template types inConstants.h
and annotate them withLLVM_TEMPLATE_ABI
.LLVM_EXPORT_TEMPLATE
toGlobalWithNodeAPI
template instantiations inConstants.cpp
.Validation
Local builds and tests to validate cross-platform compatibility. This included llvm, clang, and lldb on the following configurations: