Skip to content

[libc] Coalesce bitfield access in GPU malloc #142692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions libc/src/__support/GPU/allocator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,24 +229,34 @@ struct Slab {

// The uniform mask represents which lanes contain a uniform target pointer.
// We attempt to place these next to each other.
// TODO: We should coalesce these bits and use the result of `fetch_or` to
// search for free bits in parallel.
void *result = nullptr;
for (uint64_t mask = lane_mask; mask;
mask = gpu::ballot(lane_mask, !result)) {
uint32_t id = impl::lane_count(uniform & mask);
uint32_t index =
(gpu::broadcast_value(lane_mask, impl::xorshift32(state)) + id) %
usable_bits(chunk_size);
if (result)
continue;

uint32_t start = gpu::broadcast_value(lane_mask, impl::xorshift32(state));

uint32_t id = impl::lane_count(uniform & mask);
uint32_t index = (start + id) % usable_bits(chunk_size);
uint32_t slot = index / BITS_IN_WORD;
uint32_t bit = index % BITS_IN_WORD;
if (!result) {
uint32_t before = cpp::AtomicRef(get_bitfield()[slot])
.fetch_or(1u << bit, cpp::MemoryOrder::RELAXED);
if (~before & (1 << bit))
result = ptr_from_index(index, chunk_size);
}

// Get the mask of bits destined for the same slot and coalesce it.
uint64_t match = uniform & gpu::match_any(mask, slot);
uint32_t length = cpp::popcount(match);
uint32_t bitmask = static_cast<uint32_t>((uint64_t(1) << length) - 1)
<< bit;

uint32_t before = 0;
if (gpu::get_lane_id() == static_cast<uint32_t>(cpp::countr_zero(match)))
before = cpp::AtomicRef(get_bitfield()[slot])
.fetch_or(bitmask, cpp::MemoryOrder::RELAXED);
before = gpu::shuffle(mask, cpp::countr_zero(match), before);
if (~before & (1 << bit))
result = ptr_from_index(index, chunk_size);
else
sleep_briefly();
}

cpp::atomic_thread_fence(cpp::MemoryOrder::ACQUIRE);
Expand Down
Loading