[clang-tidy] NFCI: remove non-functional matcher from SizeofExpressionCheck #142654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nCheck This matcher would never match anything, because all record types as-written would be wrappen in an ElaboratedType. Just fixing that leads to a matcher which has too many false positives to be useful. The warning message itself is not great either, it has a hard-coded type name.
mizvekov
requested review from
whisperity,
jansvoboda11,
NagyDonat,
kazutakahirata and
HerrCai0907
|
@llvm/pr-subscribers-clang-tidy Author: Matheus Izvekov (mizvekov) ChangesThis matcher would never match anything, because all record types as-written would be wrappen in an ElaboratedType. Just fixing that leads to a matcher which has too many false positives to be useful. The warning message itself is not great either, it has a hard-coded type name. Full diff: https://github.com/llvm/llvm-project/pull/142654.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp
index f3d4c2255d86e..9eeba867f5211 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp
@@ -170,8 +170,6 @@ void SizeofExpressionCheck::registerMatchers(MatchFinder *Finder) {
const auto PointerToStructType =
hasUnqualifiedDesugaredType(pointerType(pointee(recordType())));
- const auto PointerToStructTypeWithBinding =
- type(PointerToStructType).bind("struct-type");
const auto PointerToStructExpr =
expr(hasType(hasCanonicalType(PointerToStructType)));
@@ -188,12 +186,10 @@ void SizeofExpressionCheck::registerMatchers(MatchFinder *Finder) {
ignoringParenImpCasts(unaryOperator(hasOperatorName("*")));
Finder->addMatcher(
- expr(sizeOfExpr(anyOf(has(ignoringParenImpCasts(
- expr(PointerToDetectedExpr, unless(DerefExpr),
- unless(SubscriptExprWithZeroIndex),
- unless(VarWithConstStrLiteralDecl),
- unless(cxxThisExpr())))),
- has(PointerToStructTypeWithBinding))))
+ expr(sizeOfExpr(has(ignoringParenImpCasts(expr(
+ PointerToDetectedExpr, unless(DerefExpr),
+ unless(SubscriptExprWithZeroIndex),
+ unless(VarWithConstStrLiteralDecl), unless(cxxThisExpr()))))))
.bind("sizeof-pointer"),
this);
}
@@ -354,16 +350,9 @@ void SizeofExpressionCheck::check(const MatchFinder::MatchResult &Result) {
"suspicious usage of 'sizeof(char*)'; do you mean 'strlen'?")
<< E->getSourceRange();
} else if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-pointer")) {
- if (Result.Nodes.getNodeAs<Type>("struct-type")) {
- diag(E->getBeginLoc(),
- "suspicious usage of 'sizeof(A*)' on pointer-to-aggregate type; did "
- "you mean 'sizeof(A)'?")
- << E->getSourceRange();
- } else {
- diag(E->getBeginLoc(), "suspicious usage of 'sizeof()' on an expression "
- "of pointer type")
- << E->getSourceRange();
- }
+ diag(E->getBeginLoc(), "suspicious usage of 'sizeof()' on an expression "
+ "of pointer type")
+ << E->getSourceRange();
} else if (const auto *E = Result.Nodes.getNodeAs<BinaryOperator>(
"sizeof-compare-constant")) {
diag(E->getOperatorLoc(),
|
|
@llvm/pr-subscribers-clang-tools-extra Author: Matheus Izvekov (mizvekov) ChangesThis matcher would never match anything, because all record types as-written would be wrappen in an ElaboratedType. Just fixing that leads to a matcher which has too many false positives to be useful. The warning message itself is not great either, it has a hard-coded type name. Full diff: https://github.com/llvm/llvm-project/pull/142654.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp
index f3d4c2255d86e..9eeba867f5211 100644
--- a/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp
@@ -170,8 +170,6 @@ void SizeofExpressionCheck::registerMatchers(MatchFinder *Finder) {
const auto PointerToStructType =
hasUnqualifiedDesugaredType(pointerType(pointee(recordType())));
- const auto PointerToStructTypeWithBinding =
- type(PointerToStructType).bind("struct-type");
const auto PointerToStructExpr =
expr(hasType(hasCanonicalType(PointerToStructType)));
@@ -188,12 +186,10 @@ void SizeofExpressionCheck::registerMatchers(MatchFinder *Finder) {
ignoringParenImpCasts(unaryOperator(hasOperatorName("*")));
Finder->addMatcher(
- expr(sizeOfExpr(anyOf(has(ignoringParenImpCasts(
- expr(PointerToDetectedExpr, unless(DerefExpr),
- unless(SubscriptExprWithZeroIndex),
- unless(VarWithConstStrLiteralDecl),
- unless(cxxThisExpr())))),
- has(PointerToStructTypeWithBinding))))
+ expr(sizeOfExpr(has(ignoringParenImpCasts(expr(
+ PointerToDetectedExpr, unless(DerefExpr),
+ unless(SubscriptExprWithZeroIndex),
+ unless(VarWithConstStrLiteralDecl), unless(cxxThisExpr()))))))
.bind("sizeof-pointer"),
this);
}
@@ -354,16 +350,9 @@ void SizeofExpressionCheck::check(const MatchFinder::MatchResult &Result) {
"suspicious usage of 'sizeof(char*)'; do you mean 'strlen'?")
<< E->getSourceRange();
} else if (const auto *E = Result.Nodes.getNodeAs<Expr>("sizeof-pointer")) {
- if (Result.Nodes.getNodeAs<Type>("struct-type")) {
- diag(E->getBeginLoc(),
- "suspicious usage of 'sizeof(A*)' on pointer-to-aggregate type; did "
- "you mean 'sizeof(A)'?")
- << E->getSourceRange();
- } else {
- diag(E->getBeginLoc(), "suspicious usage of 'sizeof()' on an expression "
- "of pointer type")
- << E->getSourceRange();
- }
+ diag(E->getBeginLoc(), "suspicious usage of 'sizeof()' on an expression "
+ "of pointer type")
+ << E->getSourceRange();
} else if (const auto *E = Result.Nodes.getNodeAs<BinaryOperator>(
"sizeof-compare-constant")) {
diag(E->getOperatorLoc(),
|
HerrCai0907
approved these changes
Jun 4, 2025
carlosgalvezp
approved these changes
Jun 4, 2025
carlosgalvezp
deleted the
users/mizvekov/SizeofExpressionCheck-remove-nonfunctional-matcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matcher would never match anything, because all record types as-written would be wrapped in an ElaboratedType.
Just fixing that leads to a matcher which has too many false positives to be useful.
The warning message itself is not great either, it has a hard-coded type name.