Skip to content

[lldb] Disable TestTargetWatchAddress.py on Windows x86_64 #142573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

slydiman
Copy link
Contributor

@slydiman slydiman commented Jun 3, 2025

See #142196 and llvm/llvm-zorg#452 for details.

@llvmbot
Copy link
Member

llvmbot commented Jun 3, 2025

@llvm/pr-subscribers-lldb

@llvm/pr-subscribers-platform-windows

Author: Dmitry Vasilyev (slydiman)

Changes

See #142196 and llvm/llvm-zorg#452 for details.


Full diff: https://github.com/llvm/llvm-project/pull/142573.diff

1 Files Affected:

  • (modified) lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py (+5)
diff --git a/lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py b/lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
index 7a0e42a4fc278..37fa911b3714c 100644
--- a/lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
+++ b/lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
@@ -160,6 +160,11 @@ def test_watch_address(self):
     # No size constraint on MIPS for watches
     @skipIf(archs=["mips", "mipsel", "mips64", "mips64el"])
     @skipIf(archs=["s390x"])  # Likewise on SystemZ
+    @skipIf(
+        oslist=["windows"],
+        archs=["x86_64"],
+        bugnumber="github.com/llvm/llvm-project/issues/142196",
+    )
     def test_watch_address_with_invalid_watch_size(self):
         """Exercise SBTarget.WatchpointCreateByAddress() API but pass an invalid watch_size."""
         self.build()

@DavidSpickett
Copy link
Collaborator

We think all this needs is an updated expected message, but someone will have to confirm and it might be more complex.

So I'm fine disabling this to not distract from getting the new bot online.

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slydiman slydiman merged commit a90145e into llvm:main Jun 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants