Skip to content

llvm-tli-checker: Print custom name instead of standard name #142537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: users/arsenm/target-library-info/add-tests-of-tli-checker-output
Choose a base branch
from
+24 −14
Open

llvm-tli-checker: Print custom name instead of standard name #142537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/test/Analysis/TargetLibraryInfo/arm64_32-apple-watchos.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ CHECK-NEXT: available: 'execve'
CHECK-NEXT: available: 'execvp'
CHECK-NEXT: available: 'execvpe'
CHECK-NEXT: available: 'exp'
CHECK-NEXT: available: 'exp10'
CHECK-NEXT: available: 'exp10f'
CHECK-NEXT: available: '__exp10'
CHECK-NEXT: available: '__exp10f'
CHECK-NEXT: not available: 'exp10l'
CHECK-NEXT: available: 'exp2'
CHECK-NEXT: available: 'exp2f'
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/Analysis/TargetLibraryInfo/armv7s-apple-ios7.0.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ CHECK-NEXT: available: 'execve'
CHECK-NEXT: available: 'execvp'
CHECK-NEXT: available: 'execvpe'
CHECK-NEXT: available: 'exp'
CHECK-NEXT: available: 'exp10'
CHECK-NEXT: available: 'exp10f'
CHECK-NEXT: available: '__exp10'
CHECK-NEXT: available: '__exp10f'
CHECK-NEXT: not available: 'exp10l'
CHECK-NEXT: available: 'exp2'
CHECK-NEXT: available: 'exp2f'
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/Analysis/TargetLibraryInfo/i386-apple-macosx10.7.0.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ CHECK-NEXT: available: 'fork'
CHECK-NEXT: available: 'fprintf'
CHECK-NEXT: available: 'fputc'
CHECK-NEXT: not available: 'fputc_unlocked'
CHECK-NEXT: available: 'fputs'
CHECK-NEXT: available: 'fputs$UNIX2003'
CHECK-NEXT: not available: 'fputs_unlocked'
CHECK-NEXT: available: 'fread'
CHECK-NEXT: not available: 'fread_unlocked'
Expand All @@ -308,7 +308,7 @@ CHECK-NEXT: available: 'ftello'
CHECK-NEXT: not available: 'ftello64'
CHECK-NEXT: available: 'ftrylockfile'
CHECK-NEXT: available: 'funlockfile'
CHECK-NEXT: available: 'fwrite'
CHECK-NEXT: available: 'fwrite$UNIX2003'
CHECK-NEXT: not available: 'fwrite_unlocked'
CHECK-NEXT: available: 'getc'
CHECK-NEXT: available: 'getc_unlocked'
Expand Down
10 changes: 5 additions & 5 deletions llvm/test/Analysis/TargetLibraryInfo/x86_64-pc-windows-msvc17.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ CHECK-NEXT: available: 'atoll'
CHECK-NEXT: not available: 'bcmp'
CHECK-NEXT: not available: 'bcopy'
CHECK-NEXT: not available: 'bzero'
CHECK-NEXT: available: 'cabs'
CHECK-NEXT: available: '_cabs'
CHECK-NEXT: not available: 'cabsf'
CHECK-NEXT: not available: 'cabsl'
CHECK-NEXT: available: 'calloc'
Expand All @@ -204,8 +204,8 @@ CHECK-NEXT: not available: 'chmod'
CHECK-NEXT: not available: 'chown'
CHECK-NEXT: available: 'clearerr'
CHECK-NEXT: not available: 'closedir'
CHECK-NEXT: available: 'copysign'
CHECK-NEXT: available: 'copysignf'
CHECK-NEXT: available: '_copysign'
CHECK-NEXT: available: '_copysignf'
CHECK-NEXT: not available: 'copysignl'
CHECK-NEXT: available: 'cos'
CHECK-NEXT: available: 'cosf'
Expand Down Expand Up @@ -347,8 +347,8 @@ CHECK-NEXT: not available: 'log2l'
CHECK-NEXT: not available: 'ilogb'
CHECK-NEXT: not available: 'ilogbf'
CHECK-NEXT: not available: 'ilogbl'
CHECK-NEXT: available: 'logb'
CHECK-NEXT: available: 'logbf'
CHECK-NEXT: available: '_logb'
CHECK-NEXT: available: '_logbf'
CHECK-NEXT: not available: 'logbl'
CHECK-NEXT: available: 'logf'
CHECK-NEXT: not available: 'logl'
Expand Down
16 changes: 13 additions & 3 deletions llvm/tools/llvm-tli-checker/llvm-tli-checker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,20 @@ static void dumpTLIEntries(const TargetLibraryInfo &TLI) {
for (unsigned FI = 0; FI != LibFunc::NumLibFuncs; ++FI) {
LibFunc LF = static_cast<LibFunc>(FI);
bool IsAvailable = TLI.has(LF);
StringRef FuncName = TargetLibraryInfo::getStandardName(LF);

outs() << (IsAvailable ? " " : "not ")
<< "available: " << getPrintableName(FuncName) << '\n';
outs() << (IsAvailable ? " " : "not ") << "available: ";

if (IsAvailable) {
StringRef Name = TLI.getName(LF);
// If there is a custom name, print it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// If there is a custom name, print it.
// Print the (possibly custom) name.

// TODO: Should we include the standard name in the printed line?
outs() << getPrintableName(Name);
} else {
// If it's not available, refer to it by the standard name.
outs() << getPrintableName(TargetLibraryInfo::getStandardName(LF));
}

outs() << '\n';
}
}

Expand Down
Loading