-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[clang][docs] Fix docs-clang-html. #142387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I observed that docs-clang-html is failing since llvm#142158, Warning, treated as error: tools/clang/docs/DiagnosticsReference.rst:18000:Unexpected indentation. ninja: build stopped: subcommand failed. Adding an extra empty line here fixes the build.
@llvm/pr-subscribers-clang Author: Abid Qadeer (abidh) ChangesI observed that docs-clang-html is failing since #142158 with the following: Warning, treated as error: Adding an extra empty line here fixes the build. Full diff: https://github.com/llvm/llvm-project/pull/142387.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/DiagnosticGroups.td b/clang/include/clang/Basic/DiagnosticGroups.td
index 60c650583801a..0161b3953f282 100644
--- a/clang/include/clang/Basic/DiagnosticGroups.td
+++ b/clang/include/clang/Basic/DiagnosticGroups.td
@@ -821,6 +821,7 @@ As well as one of the following:
The warning can be resolved by removing one of the conditions above. In rough
order of preference, this may be done by:
+
1. Marking the object ``const`` (if possible)
2. Moving the object's definition to a source file
3. Giving the object non-hidden visibility, e.g. using ``__attribute((visibility("default")))``.
|
I see that https://clang.llvm.org/docs/DiagnosticsReference.html#wunique-object-duplication is showing this correctly without this PR so problem may be something local to my machine. Closing it for now. |
I think I am seeing something similar on CI: https://github.com/llvm/llvm-project/actions/runs/15387162550/job/43288136977?pr=140278 |
Thanks for reporting this. I think I will reopen it. |
I wonder whether it would be better to modify |
this is tripping on CI and my machine. To repro I need to delete I find it necessary to delete the doc directory to trigger this. |
I observed that docs-clang-html is failing since #142158 with the following:
Warning, treated as error:
tools/clang/docs/DiagnosticsReference.rst:18000:Unexpected indentation. ninja: build stopped: subcommand failed.
Adding an extra empty line here fixes the build.