[OpenMP][test] Support target= in tests #142380
Open
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM is moving towards the `target=<target triple RE>` syntax in `XFAIL: ` etc., and I'll need the same in a subsequent patch. This patch adds the necessary infrastructure. Tested on `sparc-sun-solaris2.11`, `sparcv9-sun-solaris2.11`, `sparc-unknown-linux-gnu`, `sparc64-unknown-linux-gnu`, `i386-pc-solaris2.11`, `amd64-pc-solaris2.11`, `i686-pc-linux-gnu`, and `x86_64-pc-linux-gnu`.
llvmbot
added
openmp:libomp
rorth
added a commit
to rorth/llvm-project
that referenced
this pull request
Jun 2, 2025
As detailed in Issue llvm#139905, the `libomp :: misc_bugs/many-microtask-args.c` test currently `FAIL`s on SPARC: ``` # | Too many args to microtask: 17! ``` This happens on every target that lacks an assembler implementation of `__kmp_invoke_microtask`, so this patch `XFAIL`s the test on SPARC. The `target={{sparc.*}}` syntax requires PR llvm#142380. Tested on `sparc-sun-solaris2.11`, `sparcv9-sun-solaris2.11`, `sparc-unknown-linux-gnu`, and `sparc64-unknown-linux-gnu`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM is moving towards the
target=<target triple RE>syntax inXFAIL:etc., and I'll need the same in a subsequent patch.This patch adds the necessary infrastructure.
Tested on
sparc-sun-solaris2.11,sparcv9-sun-solaris2.11,sparc-unknown-linux-gnu,sparc64-unknown-linux-gnu,i386-pc-solaris2.11,amd64-pc-solaris2.11,i686-pc-linux-gnu, andx86_64-pc-linux-gnu.