Skip to content

[Sanitizer][NFC] Remove extra env from test #142247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

Conversation

ellishg
Copy link
Contributor

@ellishg ellishg commented May 31, 2025

Remove extra %env in test added by #141820

@llvmbot
Copy link
Member

llvmbot commented May 31, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Ellis Hoag (ellishg)

Changes

Remove extra %env in test added by #141820


Full diff: https://github.com/llvm/llvm-project/pull/142247.diff

1 Files Affected:

  • (modified) compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp (+2-2)
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
index 782cd0218fd22..af5187a0d3265 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_path_fail.cpp
@@ -1,10 +1,10 @@
 // RUN: %clangxx -O2 %s -o %t
 
 // Case 1: Try setting a path that is an invalid/inaccessible directory.
-// RUN: not %env %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
+// RUN: not %run %t 2>&1 | FileCheck %s --check-prefix=ERROR1
 
 // Case 2: Try setting a path that is too large.
-// RUN: not %env %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
+// RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=ERROR2
 
 #include <sanitizer/common_interface_defs.h>
 #include <stdio.h>

@ellishg ellishg merged commit 74420ce into llvm:main May 31, 2025
13 checks passed
@ellishg ellishg deleted the fix-san-test branch May 31, 2025 04:56
@llvm-ci
Copy link
Collaborator

llvm-ci commented May 31, 2025

LLVM Buildbot has detected a new failure on builder sanitizer-x86_64-linux running on sanitizer-buildbot1 while building compiler-rt at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/14746

Here is the relevant piece of the build log for the reference
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:248: warning: COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=ON, but this test suite does not support testing the just-built runtime libraries when the test compiler is configured to use different runtime libraries. Either modify this test suite to support this test configuration, or set COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=OFF to test the runtime libraries included in the compiler instead.
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:259: note: Testing using libraries in "/home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/21/lib/i386-unknown-linux-gnu"
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:237: warning: Compiler lib dir != compiler-rt lib dir
Compiler libdir:     "/home/b/sanitizer-x86_64-linux/build/build_default/lib/clang/21/lib/i386-unknown-linux-gnu"
compiler-rt libdir:  "/home/b/sanitizer-x86_64-linux/build/build_default/lib/clang/21/lib/x86_64-unknown-linux-gnu"
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:248: warning: COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=ON, but this test suite does not support testing the just-built runtime libraries when the test compiler is configured to use different runtime libraries. Either modify this test suite to support this test configuration, or set COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=OFF to test the runtime libraries included in the compiler instead.
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:259: note: Testing using libraries in "/home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/21/lib/x86_64-unknown-linux-gnu"
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/utils/lit/lit/main.py:73: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 10857 tests, 88 workers --
Testing:  0.. 10.. 20.. 
FAIL: LeakSanitizer-Standalone-i386 :: TestCases/disabler.cpp (3385 of 10857)
******************** TEST 'LeakSanitizer-Standalone-i386 :: TestCases/disabler.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
/home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang  --driver-mode=g++ -O0  -m32  -gline-tables-only -fsanitize=leak -I/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/../ /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp -o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp # RUN: at line 2
+ /home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang --driver-mode=g++ -O0 -m32 -gline-tables-only -fsanitize=leak -I/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/../ /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp -o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp
env LSAN_OPTIONS=:detect_leaks=1:report_objects=1:use_registers=0:use_stacks=0 not  /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp 2>&1 | FileCheck /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp # RUN: at line 3
+ env LSAN_OPTIONS=:detect_leaks=1:report_objects=1:use_registers=0:use_stacks=0 not /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp
+ FileCheck /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 

8 warning(s) in tests
Slowest Tests:
--------------------------------------------------------------------------
65.57s: libFuzzer-i386-default-Linux :: value-profile-switch.test
55.97s: libFuzzer-i386-libcxx-Linux :: value-profile-switch.test
54.25s: libFuzzer-i386-static-libcxx-Linux :: value-profile-switch.test
51.23s: libFuzzer-x86_64-libcxx-Linux :: fork.test
49.61s: libFuzzer-i386-libcxx-Linux :: fork.test
48.50s: libFuzzer-i386-static-libcxx-Linux :: fork_corpus_groups.test
48.46s: libFuzzer-i386-default-Linux :: fork.test
48.22s: ThreadSanitizer-x86_64 :: bench_threads.cpp
48.17s: libFuzzer-i386-libcxx-Linux :: fork_corpus_groups.test
47.23s: libFuzzer-x86_64-default-Linux :: fork_corpus_groups.test
47.09s: libFuzzer-i386-static-libcxx-Linux :: fork.test
47.03s: libFuzzer-x86_64-default-Linux :: fork.test
46.83s: libFuzzer-x86_64-static-libcxx-Linux :: fork_corpus_groups.test
46.47s: libFuzzer-i386-default-Linux :: fork_corpus_groups.test
45.57s: libFuzzer-x86_64-libcxx-Linux :: fork_corpus_groups.test
45.18s: libFuzzer-x86_64-static-libcxx-Linux :: fork.test
41.17s: libFuzzer-i386-default-Linux :: disable-leaks.test
39.56s: libFuzzer-i386-libcxx-Linux :: disable-leaks.test
39.09s: libFuzzer-x86_64-default-Linux :: out-of-process-fuzz.test
Step 14 (test compiler-rt default) failure: test compiler-rt default (failure)
...
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:248: warning: COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=ON, but this test suite does not support testing the just-built runtime libraries when the test compiler is configured to use different runtime libraries. Either modify this test suite to support this test configuration, or set COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=OFF to test the runtime libraries included in the compiler instead.
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:259: note: Testing using libraries in "/home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/21/lib/i386-unknown-linux-gnu"
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:237: warning: Compiler lib dir != compiler-rt lib dir
Compiler libdir:     "/home/b/sanitizer-x86_64-linux/build/build_default/lib/clang/21/lib/i386-unknown-linux-gnu"
compiler-rt libdir:  "/home/b/sanitizer-x86_64-linux/build/build_default/lib/clang/21/lib/x86_64-unknown-linux-gnu"
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:248: warning: COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=ON, but this test suite does not support testing the just-built runtime libraries when the test compiler is configured to use different runtime libraries. Either modify this test suite to support this test configuration, or set COMPILER_RT_TEST_STANDALONE_BUILD_LIBS=OFF to test the runtime libraries included in the compiler instead.
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:259: note: Testing using libraries in "/home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/21/lib/x86_64-unknown-linux-gnu"
llvm-lit: /home/b/sanitizer-x86_64-linux/build/llvm-project/llvm/utils/lit/lit/main.py:73: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 10857 tests, 88 workers --
Testing:  0.. 10.. 20.. 
FAIL: LeakSanitizer-Standalone-i386 :: TestCases/disabler.cpp (3385 of 10857)
******************** TEST 'LeakSanitizer-Standalone-i386 :: TestCases/disabler.cpp' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
/home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang  --driver-mode=g++ -O0  -m32  -gline-tables-only -fsanitize=leak -I/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/../ /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp -o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp # RUN: at line 2
+ /home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang --driver-mode=g++ -O0 -m32 -gline-tables-only -fsanitize=leak -I/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/../ /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp -o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp
env LSAN_OPTIONS=:detect_leaks=1:report_objects=1:use_registers=0:use_stacks=0 not  /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp 2>&1 | FileCheck /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp # RUN: at line 3
+ env LSAN_OPTIONS=:detect_leaks=1:report_objects=1:use_registers=0:use_stacks=0 not /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/test/lsan/I386LsanConfig/TestCases/Output/disabler.cpp.tmp
+ FileCheck /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lsan/TestCases/disabler.cpp

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

8 warning(s) in tests
Slowest Tests:
--------------------------------------------------------------------------
65.57s: libFuzzer-i386-default-Linux :: value-profile-switch.test
55.97s: libFuzzer-i386-libcxx-Linux :: value-profile-switch.test
54.25s: libFuzzer-i386-static-libcxx-Linux :: value-profile-switch.test
51.23s: libFuzzer-x86_64-libcxx-Linux :: fork.test
49.61s: libFuzzer-i386-libcxx-Linux :: fork.test
48.50s: libFuzzer-i386-static-libcxx-Linux :: fork_corpus_groups.test
48.46s: libFuzzer-i386-default-Linux :: fork.test
48.22s: ThreadSanitizer-x86_64 :: bench_threads.cpp
48.17s: libFuzzer-i386-libcxx-Linux :: fork_corpus_groups.test
47.23s: libFuzzer-x86_64-default-Linux :: fork_corpus_groups.test
47.09s: libFuzzer-i386-static-libcxx-Linux :: fork.test
47.03s: libFuzzer-x86_64-default-Linux :: fork.test
46.83s: libFuzzer-x86_64-static-libcxx-Linux :: fork_corpus_groups.test
46.47s: libFuzzer-i386-default-Linux :: fork_corpus_groups.test
45.57s: libFuzzer-x86_64-libcxx-Linux :: fork_corpus_groups.test
45.18s: libFuzzer-x86_64-static-libcxx-Linux :: fork.test
41.17s: libFuzzer-i386-default-Linux :: disable-leaks.test
39.56s: libFuzzer-i386-libcxx-Linux :: disable-leaks.test
39.09s: libFuzzer-x86_64-default-Linux :: out-of-process-fuzz.test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants