[utils] Fix utils/demangle_tree.py:parse_line to correctly check for closing parenthesis #142153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for closing parenthesis
Previously, parse_line incorrectly repeated the check for open_paren
instead of verifying the presence of a closing parenthesis. This caused
inputs with an unmatched opening parenthesis to be parsed incorrectly.
For example:
print(parse_line('?foo (bar'))
→ before: ('?foo', 'ba') [incorrect]
→ after: (None, None) [correct]
Fixed the condition to properly check close_paren.
sivan-shani
changed the title
sivan-shani
requested review from
zjturner
and removed request for
zjturner and
tru
davemgreen
approved these changes
Jun 2, 2025
sivan-shani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, parse_line incorrectly repeated the check for open_paren instead of verifying the presence of a closing parenthesis. This caused inputs with an unmatched opening parenthesis to be parsed incorrectly.
For example:
print(parse_line('?foo (bar'))
→ before: ('?foo', 'ba') [incorrect]
→ after: (None, None) [correct]
Fixed the condition to properly check close_paren.