[libc++] Update GDB pretty-printer to work with GDB 17

[kotborealis]

Fixed an issue in libcxx/utils/gdb/libcxx/printers.py.

With gdb 17 (binutils 2_44) pretty-printers do not work anymore because calls to gdb.printing requires import gdb.printing statement, which was missing from the printers.py.

Broken after commit binutils-gdb/fc14343205d3a68db1fc139e4af9796be208fab4, and import gdb.printing was first referenced in binutils-gdb/ee06c79b0fefd5e4ed5e7a1171dc3440130e41da

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: kotborealis (kotborealis)

Changes

Fixed an issue in libcxx/utils/gdb/libcxx/printers.py.

With gdb 17 (binutils 2_44) pretty-printers do not work anymore because calls to gdb.printing requires import gdb.printing statement, which was missing from the printers.py.

Broken after commit binutils-gdb/fc14343205d3a68db1fc139e4af9796be208fab4, and import gdb.printing was first referenced in binutils-gdb/ee06c79b0fefd5e4ed5e7a1171dc3440130e41da

---

Full diff: https://github.com/llvm/llvm-project/pull/142106.diff

1 Files Affected:

• (modified) libcxx/utils/gdb/libcxx/printers.py (+1)

diff --git a/libcxx/utils/gdb/libcxx/printers.py b/libcxx/utils/gdb/libcxx/printers.py
index e3d5d87aca325..90bc54d987ee8 100644
--- a/libcxx/utils/gdb/libcxx/printers.py
+++ b/libcxx/utils/gdb/libcxx/printers.py
@@ -14,6 +14,7 @@
 
 import re
 import gdb
+import gdb.printing
 
 # One under-documented feature of the gdb pretty-printer API
 # is that clients can call any other member of the API

[chestnykh]

LGTM, thanks!

[ldionne]

Thanks for the fix. LGTM, pending CI.

[chestnykh]

The branch was updated to pass CI which had infrastructural errors

[ldionne]

The branch was updated to pass CI which had infrastructural errors

Yeah, we're having a lot of infra issues. If it fails again, don't do anything, I'll restart just the jobs that failed.