[libc++] Avoid spuriously unsupporting the new FTM tests #142024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new FTM tests contain text that they validate against to check the output of the FTM generation script. However, that text lexically contains the characters `// UNSUPPORTED: <...>`, which leads Lit to make the whole test unsupported under these conditions. To prevent that from happening, an `# END.` block can be used to prevent Lit from looking further into the file for directives.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesThe new FTM tests contain text that they validate against to check the output of the FTM generation script. However, that text lexically contains the characters Full diff: https://github.com/llvm/llvm-project/pull/142024.diff 1 Files Affected:
diff --git a/libcxx/test/libcxx/feature_test_macro/generate_header_test.sh.py b/libcxx/test/libcxx/feature_test_macro/generate_header_test.sh.py
index 98acfeacd0181..789a0bc25a87b 100644
--- a/libcxx/test/libcxx/feature_test_macro/generate_header_test.sh.py
+++ b/libcxx/test/libcxx/feature_test_macro/generate_header_test.sh.py
@@ -7,6 +7,7 @@
# ===----------------------------------------------------------------------===##
# RUN: %{python} %s %{libcxx-dir}/utils %{libcxx-dir}/test/libcxx/feature_test_macro/test_data.json %t/tests
+# END.
import os
import sys
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new FTM tests contain text that they validate against to check the output of the FTM generation script. However, that text lexically contains the characters
// UNSUPPORTED: <...>, which leads Lit to make the whole test unsupported under these conditions. To prevent that from happening, an# END.block can be used to prevent Lit from looking further into the file for directives.