[lldb-dap] fix config value comparison #142017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) ChangesFix TypeSCript comparison (when defining an empty config string like Full diff: https://github.com/llvm/llvm-project/pull/142017.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts b/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
index 957bc5e1eb956..316ffaf47c3d2 100644
--- a/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
+++ b/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
@@ -84,7 +84,7 @@ export class LLDBDapConfigurationProvider
continue;
}
const value = config.get(key);
- if (!value || value === cfg.default) {
+ if (value === undefined || value === cfg.default) {
continue;
}
switch (cfg.type) {
|
ashgti
approved these changes
May 29, 2025
JDevlieghere
approved these changes
May 29, 2025
google-yfyang
pushed a commit
to google-yfyang/llvm-project
that referenced
this pull request
May 29, 2025
Fix TypeSCript comparison (when defining an empty config string like `commandEscapePrefix=""` it would skip it)
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Fix TypeSCript comparison (when defining an empty config string like `commandEscapePrefix=""` it would skip it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TypeSCript comparison (when defining an empty config string like
commandEscapePrefix=""it would skip it)