[clang-doc] fix FileCheck for conversion function HTML test #141976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to add RUN for the test which revealed a problem with the test.
|
@llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) ChangesThe HTML FileCheck was missing the RUN command. Fixing that revealed an error in the HTML check. Full diff: https://github.com/llvm/llvm-project/pull/141976.diff 1 Files Affected:
diff --git a/clang-tools-extra/test/clang-doc/conversion_function.cpp b/clang-tools-extra/test/clang-doc/conversion_function.cpp
index bf97d85661346..0200a578219ee 100644
--- a/clang-tools-extra/test/clang-doc/conversion_function.cpp
+++ b/clang-tools-extra/test/clang-doc/conversion_function.cpp
@@ -4,7 +4,7 @@
// RUN: find %t/ -regex ".*/[0-9A-F]*.yaml" -exec cat {} ";" | FileCheck %s --check-prefix=CHECK-YAML
// RUN: clang-doc --format=html --output=%t --executor=standalone %s
-// FileCheck %s --check-prefix=CHECK-HTML
+// RUN: FileCheck %s < %t/GlobalNamespace/MyStruct.html --check-prefix=CHECK-HTML
template <typename T>
struct MyStruct {
@@ -14,5 +14,5 @@ struct MyStruct {
// Output correct conversion names.
// CHECK-YAML: Name: 'operator T'
-// CHECK-HTML: <h3 id='{{[0-9A-F]*}}'>operator T</h3>
+// CHECK-HTML: <h3 id="{{[0-9A-F]*}}">operator T</h3>
// CHECK-HTML: <p>public T operator T()</p>
|
|
Jeez. We're so disciplined ... LGTM Assuming CI passes. |
ilovepi
approved these changes
May 29, 2025
|
CI passed besides the Linux test. Identical to what was discussed in #138065 |
svkeerthy
pushed a commit
that referenced
this pull request
May 29, 2025
The HTML FileCheck was missing the RUN command. Fixing that revealed an error in the HTML check.
google-yfyang
pushed a commit
to google-yfyang/llvm-project
that referenced
this pull request
May 29, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML FileCheck was missing the RUN command. Fixing that revealed an error in the HTML check.