[Github] Fix TODO after removal of continue on error #141896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using continue-on-error within the workflows to prevent sending out notifications for workflow failures. We worked around this in the metrics container to see what was actually failing/passing by looking at the individual steps. Now that we have gotten rid of the continue-on-error flag, we just have to look at the job status.
boomanaiden154
requested review from
dschuff,
lnihlen,
gburgessiv,
Keenuts and
cmtice
lnihlen
approved these changes
May 29, 2025
cmtice
approved these changes
May 29, 2025
svkeerthy
pushed a commit
that referenced
this pull request
May 29, 2025
Previously we were using continue-on-error within the workflows to prevent sending out notifications for workflow failures. We worked around this in the metrics container to see what was actually failing/passing by looking at the individual steps. Now that we have gotten rid of the continue-on-error flag, we just have to look at the job status.
google-yfyang
pushed a commit
to google-yfyang/llvm-project
that referenced
this pull request
May 29, 2025
Previously we were using continue-on-error within the workflows to prevent sending out notifications for workflow failures. We worked around this in the metrics container to see what was actually failing/passing by looking at the individual steps. Now that we have gotten rid of the continue-on-error flag, we just have to look at the job status.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Previously we were using continue-on-error within the workflows to prevent sending out notifications for workflow failures. We worked around this in the metrics container to see what was actually failing/passing by looking at the individual steps. Now that we have gotten rid of the continue-on-error flag, we just have to look at the job status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using continue-on-error within the workflows to prevent sending out notifications for workflow failures. We worked around this in the metrics container to see what was actually failing/passing by looking at the individual steps. Now that we have gotten rid of the continue-on-error flag, we just have to look at the job status.