Skip to content

[NFC][DWP] Make getContributionIndex static #141708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented May 28, 2025

Remove getContributionIndex declaration from header and make it static as it seems to be only used within the .cpp file.

@jurahul jurahul marked this pull request as ready for review May 28, 2025 13:22
@jurahul jurahul requested a review from kazutakahirata May 28, 2025 13:23
Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jurahul jurahul force-pushed the dwm_make_getContributionIndex_static branch from a477a4c to 644c12e Compare May 30, 2025 23:43
@jurahul jurahul force-pushed the dwm_make_getContributionIndex_static branch from 644c12e to 5ae8ed0 Compare May 31, 2025 12:47
@jurahul jurahul changed the title [NFC][DWP] Make getContributionIndex static. [NFC][DWP] Make getContributionIndex static May 31, 2025
@jurahul jurahul merged commit 2cbe8df into llvm:main May 31, 2025
11 checks passed
@jurahul jurahul deleted the dwm_make_getContributionIndex_static branch May 31, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants