Skip to content

[clang][bytecode][NFC] Remove Frame.cpp #140750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

[clang][bytecode][NFC] Remove Frame.cpp #140750

merged 1 commit into from
May 20, 2025

Conversation

tbaederr
Copy link
Contributor

The file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files.

The file was basically empty. The actual implementation for function
frames of the two interpreter life in their own respective files.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:bytecode Issues for the clang bytecode constexpr interpreter labels May 20, 2025
@llvmbot
Copy link
Member

llvmbot commented May 20, 2025

@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)

Changes

The file was basically empty. The actual implementation for function frames of the two interpreter life in their own respective files.


Full diff: https://github.com/llvm/llvm-project/pull/140750.diff

3 Files Affected:

  • (removed) clang/lib/AST/ByteCode/Frame.cpp (-14)
  • (modified) clang/lib/AST/ByteCode/Frame.h (+1-1)
  • (modified) clang/lib/AST/CMakeLists.txt (-1)
diff --git a/clang/lib/AST/ByteCode/Frame.cpp b/clang/lib/AST/ByteCode/Frame.cpp
deleted file mode 100644
index 16134aa1db36c..0000000000000
--- a/clang/lib/AST/ByteCode/Frame.cpp
+++ /dev/null
@@ -1,14 +0,0 @@
-//===--- Frame.cpp - Call frame for the VM and AST Walker -------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#include "Frame.h"
-
-using namespace clang;
-using namespace clang::interp;
-
-Frame::~Frame() {}
diff --git a/clang/lib/AST/ByteCode/Frame.h b/clang/lib/AST/ByteCode/Frame.h
index 079e4259b0ae8..b67a77a368997 100644
--- a/clang/lib/AST/ByteCode/Frame.h
+++ b/clang/lib/AST/ByteCode/Frame.h
@@ -24,7 +24,7 @@ namespace interp {
 /// Base class for stack frames, shared between VM and walker.
 class Frame {
 public:
-  virtual ~Frame();
+  virtual ~Frame() = default;
 
   /// Generates a human-readable description of the call site.
   virtual void describe(llvm::raw_ostream &OS) const = 0;
diff --git a/clang/lib/AST/CMakeLists.txt b/clang/lib/AST/CMakeLists.txt
index b5cd14b915673..d4fd7a7f16d53 100644
--- a/clang/lib/AST/CMakeLists.txt
+++ b/clang/lib/AST/CMakeLists.txt
@@ -74,7 +74,6 @@ add_clang_library(clangAST
   ByteCode/Descriptor.cpp
   ByteCode/Disasm.cpp
   ByteCode/EvalEmitter.cpp
-  ByteCode/Frame.cpp
   ByteCode/Function.cpp
   ByteCode/FunctionPointer.cpp
   ByteCode/InterpBuiltin.cpp

@tbaederr tbaederr merged commit 9260d31 into llvm:main May 20, 2025
15 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented May 21, 2025

LLVM Buildbot has detected a new failure on builder clang-ppc64-aix running on aix-ppc64 while building clang at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/3702

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'lit :: timeout-hang.py' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 13
not env -u FILECHECK_OPTS "/home/llvm/llvm-external-buildbots/workers/env/bin/python3.11" /home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/utils/lit/lit.py -j1 --order=lexical Inputs/timeout-hang/run-nonexistent.txt  --timeout=1 --param external=0 | "/home/llvm/llvm-external-buildbots/workers/env/bin/python3.11" /home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/build/utils/lit/tests/timeout-hang.py 1
# executed command: not env -u FILECHECK_OPTS /home/llvm/llvm-external-buildbots/workers/env/bin/python3.11 /home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/utils/lit/lit.py -j1 --order=lexical Inputs/timeout-hang/run-nonexistent.txt --timeout=1 --param external=0
# .---command stderr------------
# | lit.py: /home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 1 seconds was requested on the command line. Forcing timeout to be 1 seconds.
# `-----------------------------
# executed command: /home/llvm/llvm-external-buildbots/workers/env/bin/python3.11 /home/llvm/llvm-external-buildbots/workers/aix-ppc64/clang-ppc64-aix/build/utils/lit/tests/timeout-hang.py 1
# .---command stdout------------
# | Testing took as long or longer than timeout
# `-----------------------------
# error: command failed with exit status: 1

--

********************


kostasalv pushed a commit to kostasalv/llvm-project that referenced this pull request May 21, 2025
The file was basically empty. The actual implementation for function
frames of the two interpreter life in their own respective files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:bytecode Issues for the clang bytecode constexpr interpreter clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants