[clang][Driver][test][NFC] Adjust test for targets with no cc1as #140490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have the test accept use of the toolchain assembler instead of `-cc1as` as some targets, such as AIX, do not use `-cc1as`.
hubert-reinterpretcast
requested review from
jmmartinez,
daltenty,
jakeegan,
yxsamliu,
lamb-j and
lei137
llvmbot
added
clang
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Hubert Tong (hubert-reinterpretcast) ChangesHave the test accept use of the toolchain assembler instead of Full diff: https://github.com/llvm/llvm-project/pull/140490.diff 1 Files Affected:
diff --git a/clang/test/Driver/no-integrated-cpp.c b/clang/test/Driver/no-integrated-cpp.c
index a7dc847f08a67..2094d4247184f 100644
--- a/clang/test/Driver/no-integrated-cpp.c
+++ b/clang/test/Driver/no-integrated-cpp.c
@@ -22,7 +22,7 @@
// SRC-SAVE-SAME: "-o" "[[ASM:.*.s]]"
// SRC-SAVE-SAME: "-x" "ir" "[[BITCODE]]"
//
-// SRC-SAVE-NEXT: "-cc1as"
+// SRC-SAVE-NEXT: {{"-cc1as"|"[^"]*/as"}}
// SRC-SAVE-SAME: "-o" "a.o" "[[ASM]]"
//
// RUN: %clang -O2 %t.i -c -o a.o -no-integrated-cpp -### 2>&1 | FileCheck %s --check-prefixes=PRE
@@ -41,7 +41,7 @@
// PRE-SAVE-SAME: "-o" "[[ASM:.*.s]]"
// PRE-SAVE-SAME: "-x" "ir" "[[BITCODE]]"
//
-// PRE-SAVE-NEXT: "-cc1as"
+// PRE-SAVE-NEXT: {{"-cc1as"|"[^"]*/as"}}
// PRE-SAVE-SAME: "-o" "a.o" "[[ASM]]"
//
// RUN: %clang -O2 %s -c -emit-llvm -o a.bc -no-integrated-cpp -### 2>&1 | FileCheck %s --check-prefixes=LLVM
|
|
This PR addresses the failure seen in https://lab.llvm.org/buildbot/#/builders/64/builds/3661/steps/6/logs/FAIL__Clang__no-integrated-cpp_c. |
hubert-reinterpretcast
deleted the
users/hubert-reinterpretcast/nfc-test-fix-cc1as-AIX
branch
ajaden-codes
pushed a commit
to Jaddyen/llvm-project
that referenced
this pull request
Jun 6, 2025
…m#140490) Have the test accept use of the toolchain assembler instead of `-cc1as` as some targets, such as AIX, do not use `-cc1as`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the test accept use of the toolchain assembler instead of
-cc1asas some targets, such as AIX, do not use-cc1as.