[WIP] ABI Lowering Library #140112
Draft
[WIP] ABI Lowering Library #140112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
May 23, 2025
| TypeKind Kind; | ||
| uint64_t SizeInBits; | ||
| uint64_t AlignInBits; | ||
| bool IsExplicitlyAligned; |
There was a problem hiding this comment.
We're probably going to need more than IsExplicitAligned, but we can deal with it when we get to it.
llvm/include/llvm/ABI/Types.h
Outdated
| bool IsSigned; | ||
|
|
||
| public: | ||
| IntegerType(uint64_t BitWidth, uint64_t Align, bool Signed) |
There was a problem hiding this comment.
We'll have to distinguish __int128 and _BitInt(128) here, but we can deal with that when we get to it.
| class VectorType : public Type { | ||
| private: | ||
| const Type *ElementType; | ||
| uint64_t NumElements; |
There was a problem hiding this comment.
Should probably be ElementCount for scalable vector support.
| StructPacking Pack = StructPacking::Default) { | ||
| FieldInfo *FieldArray = Allocator.Allocate<FieldInfo>(Fields.size()); | ||
|
|
||
| for (size_t I = 0; I < Fields.size(); ++I) { |
There was a problem hiding this comment.
nit: Avoid braces for single line ifs.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
nikic
reviewed
May 27, 2025
nikic
reviewed
May 30, 2025
nikic
reviewed
Jun 1, 2025
nikic
reviewed
Jun 4, 2025
| continue; | ||
|
|
||
| const RecordType *BaseRT = Base.getType()->getAs<RecordType>(); | ||
| if (!BaseRT) |
There was a problem hiding this comment.
I don't think this can fail. Assert instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR details the implementation details of the proposed ABI lowering library.