Skip to content

[SPIRV][libc] Introduce SPIR-V target for 'libc' #137310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VyacheslavLevytskyy
Copy link
Contributor

@VyacheslavLevytskyy VyacheslavLevytskyy commented Apr 25, 2025

This is to introduce SPIR-V target for the GPU C library.

Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/lib/Headers/spirvintrin.h libc/benchmarks/gpu/timing/spirv64/timing.h libc/src/math/spirv64/acos.cpp libc/src/math/spirv64/acosf.cpp libc/src/math/spirv64/acosh.cpp libc/src/math/spirv64/acoshf.cpp libc/src/math/spirv64/asin.cpp libc/src/math/spirv64/asinf.cpp libc/src/math/spirv64/asinh.cpp libc/src/math/spirv64/asinhf.cpp libc/src/math/spirv64/atan.cpp libc/src/math/spirv64/atan2.cpp libc/src/math/spirv64/atan2f.cpp libc/src/math/spirv64/atanf.cpp libc/src/math/spirv64/atanh.cpp libc/src/math/spirv64/atanhf.cpp libc/src/math/spirv64/ceil.cpp libc/src/math/spirv64/ceilf.cpp libc/src/math/spirv64/copysign.cpp libc/src/math/spirv64/copysignf.cpp libc/src/math/spirv64/cos.cpp libc/src/math/spirv64/cosf.cpp libc/src/math/spirv64/cosh.cpp libc/src/math/spirv64/coshf.cpp libc/src/math/spirv64/declarations.h libc/src/math/spirv64/erf.cpp libc/src/math/spirv64/erff.cpp libc/src/math/spirv64/exp.cpp libc/src/math/spirv64/exp10.cpp libc/src/math/spirv64/exp10f.cpp libc/src/math/spirv64/exp2.cpp libc/src/math/spirv64/exp2f.cpp libc/src/math/spirv64/expf.cpp libc/src/math/spirv64/expm1.cpp libc/src/math/spirv64/expm1f.cpp libc/src/math/spirv64/fabs.cpp libc/src/math/spirv64/fabsf.cpp libc/src/math/spirv64/fdim.cpp libc/src/math/spirv64/fdimf.cpp libc/src/math/spirv64/floor.cpp libc/src/math/spirv64/floorf.cpp libc/src/math/spirv64/fma.cpp libc/src/math/spirv64/fmaf.cpp libc/src/math/spirv64/fmax.cpp libc/src/math/spirv64/fmaxf.cpp libc/src/math/spirv64/fmin.cpp libc/src/math/spirv64/fminf.cpp libc/src/math/spirv64/fmod.cpp libc/src/math/spirv64/fmodf.cpp libc/src/math/spirv64/frexp.cpp libc/src/math/spirv64/frexpf.cpp libc/src/math/spirv64/hypot.cpp libc/src/math/spirv64/hypotf.cpp libc/src/math/spirv64/ilogb.cpp libc/src/math/spirv64/ilogbf.cpp libc/src/math/spirv64/ldexp.cpp libc/src/math/spirv64/ldexpf.cpp libc/src/math/spirv64/lgamma.cpp libc/src/math/spirv64/lgamma_r.cpp libc/src/math/spirv64/llrint.cpp libc/src/math/spirv64/llrintf.cpp libc/src/math/spirv64/log.cpp libc/src/math/spirv64/log10.cpp libc/src/math/spirv64/log10f.cpp libc/src/math/spirv64/log1p.cpp libc/src/math/spirv64/log1pf.cpp libc/src/math/spirv64/log2.cpp libc/src/math/spirv64/log2f.cpp libc/src/math/spirv64/logb.cpp libc/src/math/spirv64/logbf.cpp libc/src/math/spirv64/logf.cpp libc/src/math/spirv64/lrint.cpp libc/src/math/spirv64/lrintf.cpp libc/src/math/spirv64/nearbyint.cpp libc/src/math/spirv64/nearbyintf.cpp libc/src/math/spirv64/nextafter.cpp libc/src/math/spirv64/nextafterf.cpp libc/src/math/spirv64/platform.h libc/src/math/spirv64/powf.cpp libc/src/math/spirv64/powi.cpp libc/src/math/spirv64/powif.cpp libc/src/math/spirv64/remainder.cpp libc/src/math/spirv64/remainderf.cpp libc/src/math/spirv64/remquo.cpp libc/src/math/spirv64/remquof.cpp libc/src/math/spirv64/rint.cpp libc/src/math/spirv64/rintf.cpp libc/src/math/spirv64/round.cpp libc/src/math/spirv64/roundf.cpp libc/src/math/spirv64/scalbn.cpp libc/src/math/spirv64/scalbnf.cpp libc/src/math/spirv64/sin.cpp libc/src/math/spirv64/sincos.cpp libc/src/math/spirv64/sincosf.cpp libc/src/math/spirv64/sinf.cpp libc/src/math/spirv64/sinh.cpp libc/src/math/spirv64/sinhf.cpp libc/src/math/spirv64/sqrt.cpp libc/src/math/spirv64/sqrtf.cpp libc/src/math/spirv64/tan.cpp libc/src/math/spirv64/tanf.cpp libc/src/math/spirv64/tanh.cpp libc/src/math/spirv64/tanhf.cpp libc/src/math/spirv64/tgamma.cpp libc/src/math/spirv64/tgammaf.cpp libc/src/math/spirv64/trunc.cpp libc/src/math/spirv64/truncf.cpp libc/startup/gpu/spirv64/start.cpp clang/lib/Headers/gpuintrin.h libc/benchmarks/gpu/timing/timing.h libc/include/llvm-libc-macros/math-macros.h libc/include/llvm-libc-macros/signal-macros.h libc/include/llvm-libc-macros/time-macros.h libc/include/llvm-libc-types/fenv_t.h libc/shared/rpc_util.h libc/src/__support/macros/properties/architectures.h libc/src/__support/macros/properties/cpu_features.h libc/src/__support/time/gpu/time_utils.h
View the diff from clang-format here.
diff --git a/libc/src/math/spirv64/declarations.h b/libc/src/math/spirv64/declarations.h
index 24fa43f2b..437a5b592 100644
--- a/libc/src/math/spirv64/declarations.h
+++ b/libc/src/math/spirv64/declarations.h
@@ -13,8 +13,7 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
-extern "C" {
-}
+extern "C" {}
 
 } // namespace LIBC_NAMESPACE_DECL
 
diff --git a/libc/src/math/spirv64/platform.h b/libc/src/math/spirv64/platform.h
index 68639ef3f..7044747d1 100644
--- a/libc/src/math/spirv64/platform.h
+++ b/libc/src/math/spirv64/platform.h
@@ -67,7 +67,9 @@ LIBC_INLINE long lrintf(float x) { return __builtin_lrintf(x); }
 LIBC_INLINE double nextafter(double x, double y) {
   return __builtin_nextafter(x, y);
 }
-LIBC_INLINE float nextafterf(float x, float y) { return __builtin_nextafterf(x, y); }
+LIBC_INLINE float nextafterf(float x, float y) {
+  return __builtin_nextafterf(x, y);
+}
 LIBC_INLINE double pow(double x, double y) { return __builtin_pow(x, y); }
 LIBC_INLINE float powf(float x, float y) { return __builtin_powf(x, y); }
 LIBC_INLINE double sin(double x) { return __builtin_sin(x); }
diff --git a/libc/src/math/spirv64/powf.cpp b/libc/src/math/spirv64/powf.cpp
index 3cc6ab15f..7b99922b5 100644
--- a/libc/src/math/spirv64/powf.cpp
+++ b/libc/src/math/spirv64/powf.cpp
@@ -14,6 +14,8 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
-LLVM_LIBC_FUNCTION(float, powf, (float x, float y)) { return __builtin_powf(x, y); }
+LLVM_LIBC_FUNCTION(float, powf, (float x, float y)) {
+  return __builtin_powf(x, y);
+}
 
 } // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/spirv64/powi.cpp b/libc/src/math/spirv64/powi.cpp
index a1601743f..d3cd53f94 100644
--- a/libc/src/math/spirv64/powi.cpp
+++ b/libc/src/math/spirv64/powi.cpp
@@ -14,6 +14,8 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
-LLVM_LIBC_FUNCTION(double, powi, (double x, int y)) { return __builtin_powi(x, y); }
+LLVM_LIBC_FUNCTION(double, powi, (double x, int y)) {
+  return __builtin_powi(x, y);
+}
 
 } // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/src/math/spirv64/powif.cpp b/libc/src/math/spirv64/powif.cpp
index dfe40b6aa..7580a9aca 100644
--- a/libc/src/math/spirv64/powif.cpp
+++ b/libc/src/math/spirv64/powif.cpp
@@ -14,6 +14,8 @@
 
 namespace LIBC_NAMESPACE_DECL {
 
-LLVM_LIBC_FUNCTION(float, powif, (float x, int y)) { return __builtin_powif(x, y); }
+LLVM_LIBC_FUNCTION(float, powif, (float x, int y)) {
+  return __builtin_powif(x, y);
+}
 
 } // namespace LIBC_NAMESPACE_DECL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant