Skip to content

[lldb] Quote module name in error message #137083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

adrian-prantl
Copy link
Collaborator

@adrian-prantl adrian-prantl commented Apr 23, 2025

rdar://149554634

@llvmbot
Copy link
Member

llvmbot commented Apr 23, 2025

@llvm/pr-subscribers-lldb

Author: Adrian Prantl (adrian-prantl)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/137083.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp (+1-1)
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
index 5b1353454a1c6..3eb5c3b2101b5 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
@@ -330,7 +330,7 @@ bool ClangModulesDeclVendorImpl::AddModule(const SourceModule &module,
     }
   }
   if (!HS.lookupModule(module.path.front().GetStringRef())) {
-    error_stream.Printf("error: Header search couldn't locate module %s\n",
+    error_stream.Printf("error: Header search couldn't locate module '%s'\n",
                         module.path.front().AsCString());
     return false;
   }

@adrian-prantl adrian-prantl merged commit de2f939 into llvm:main Apr 23, 2025
10 of 11 checks passed
adrian-prantl added a commit to adrian-prantl/llvm-project that referenced this pull request Apr 23, 2025
rdar://149554634
(cherry picked from commit de2f939)
adrian-prantl added a commit to swiftlang/llvm-project that referenced this pull request Apr 24, 2025
…e-6.2-lldb-Quote-module-name-in-error-message-137083

[Cherry-pick into swift/release/6.2] [lldb] Quote module name in error message (llvm#137083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants