[Offload] Fix missing dependency on `clang-nvlink-wrapper' #137033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It's possible that this won't be built in time for the runtimes build. Add this as a dependency. We will also need to make this future proof and loop over all the enabled targets, but that's a later update.
jhuber6
requested review from
ajarmusch,
jdoerfert,
Meinersbur,
shiltian and
tstellar
|
I thought runtime build kicks off at the end of the rest of the build? |
Kind of? There's still explicit dependencies we need since not every target will be built. That's why these already exist. |
tstellar
approved these changes
Apr 23, 2025
Sorry about that, I didn't notice that this was missing because it's correctly in the |
ajarmusch
approved these changes
Apr 23, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/13/builds/6734 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/42/builds/4270 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2775 Here is the relevant piece of the build log for the reference |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Summary: It's possible that this won't be built in time for the runtimes build. Add this as a dependency. We will also need to make this future proof and loop over all the enabled targets, but that's a later update.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Summary: It's possible that this won't be built in time for the runtimes build. Add this as a dependency. We will also need to make this future proof and loop over all the enabled targets, but that's a later update.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Summary: It's possible that this won't be built in time for the runtimes build. Add this as a dependency. We will also need to make this future proof and loop over all the enabled targets, but that's a later update.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
Summary: It's possible that this won't be built in time for the runtimes build. Add this as a dependency. We will also need to make this future proof and loop over all the enabled targets, but that's a later update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It's possible that this won't be built in time for the runtimes build.
Add this as a dependency. We will also need to make this future proof
and loop over all the enabled targets, but that's a later update.