Skip to content

[mlir][memref] Fix typo in BuiltinAttributeInterfaces description #136774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azecevicTT
Copy link

No description provided.

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir mlir:ods labels Apr 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 22, 2025

@llvm/pr-subscribers-mlir-ods

Author: Aleksandar Zecevic (azecevicTT)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/136774.diff

1 Files Affected:

  • (modified) mlir/include/mlir/IR/BuiltinAttributeInterfaces.td (+2-2)
diff --git a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
index 6220d80264bdf..6cf8729b92c83 100644
--- a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
+++ b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
@@ -480,8 +480,8 @@ def MemRefLayoutAttrInterface : AttrInterface<"MemRefLayoutAttrInterface"> {
 
     Note: the MemRef type's layout is assumed to represent simple strided buffer
     layout. For more complicated case, like sparse storage buffers,
-    it is preferable to use separate type with more specic layout, rather then
-    introducing extra complexity to the builtin MemRef type.
+    it is preferable to use a separate type with a more specific layout, rather
+    than introducing extra complexity to the builtin MemRef type.
   }];
 
   let methods = [

@llvmbot
Copy link
Member

llvmbot commented Apr 22, 2025

@llvm/pr-subscribers-mlir

Author: Aleksandar Zecevic (azecevicTT)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/136774.diff

1 Files Affected:

  • (modified) mlir/include/mlir/IR/BuiltinAttributeInterfaces.td (+2-2)
diff --git a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
index 6220d80264bdf..6cf8729b92c83 100644
--- a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
+++ b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
@@ -480,8 +480,8 @@ def MemRefLayoutAttrInterface : AttrInterface<"MemRefLayoutAttrInterface"> {
 
     Note: the MemRef type's layout is assumed to represent simple strided buffer
     layout. For more complicated case, like sparse storage buffers,
-    it is preferable to use separate type with more specic layout, rather then
-    introducing extra complexity to the builtin MemRef type.
+    it is preferable to use a separate type with a more specific layout, rather
+    than introducing extra complexity to the builtin MemRef type.
   }];
 
   let methods = [

@llvmbot
Copy link
Member

llvmbot commented Apr 22, 2025

@llvm/pr-subscribers-mlir-core

Author: Aleksandar Zecevic (azecevicTT)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/136774.diff

1 Files Affected:

  • (modified) mlir/include/mlir/IR/BuiltinAttributeInterfaces.td (+2-2)
diff --git a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
index 6220d80264bdf..6cf8729b92c83 100644
--- a/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
+++ b/mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
@@ -480,8 +480,8 @@ def MemRefLayoutAttrInterface : AttrInterface<"MemRefLayoutAttrInterface"> {
 
     Note: the MemRef type's layout is assumed to represent simple strided buffer
     layout. For more complicated case, like sparse storage buffers,
-    it is preferable to use separate type with more specic layout, rather then
-    introducing extra complexity to the builtin MemRef type.
+    it is preferable to use a separate type with a more specific layout, rather
+    than introducing extra complexity to the builtin MemRef type.
   }];
 
   let methods = [

Copy link
Contributor

@CoTinker CoTinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir:ods mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants