Skip to content

[CIR] Change 'CIR-int' to use a 'APIntParameter' argument #136713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

erichkeane
Copy link
Collaborator

After 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter.

I don't believe we need to put this in the incubator, as it'll get this in the same
pulldown as the diagnostic.

After 4bcc414 an APInt parameter diagnoses, so this switches
us to APIntParameter.
@erichkeane erichkeane requested review from xlauko and andykaylor April 22, 2025 15:32
@llvmbot llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels Apr 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 22, 2025

@llvm/pr-subscribers-clangir

@llvm/pr-subscribers-clang

Author: Erich Keane (erichkeane)

Changes

After 4bcc414 an APInt parameter diagnoses, so this switches us to APIntParameter.

I don't believe we need to put this in the incubator, as it'll get this in the same
pulldown as the diagnostic.


Full diff: https://github.com/llvm/llvm-project/pull/136713.diff

1 Files Affected:

  • (modified) clang/include/clang/CIR/Dialect/IR/CIRAttrs.td (+1-1)
diff --git a/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td b/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td
index dfe15a10fa54e..293b83e70eff7 100644
--- a/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td
+++ b/clang/include/clang/CIR/Dialect/IR/CIRAttrs.td
@@ -114,7 +114,7 @@ def IntAttr : CIR_Attr<"Int", "int", [TypedAttrInterface]> {
     value of the specified integer type.
   }];
   let parameters = (ins AttributeSelfTypeParameter<"">:$type,
-                        "llvm::APInt":$value);
+                        APIntParameter<"">:$value);
   let builders = [
     AttrBuilderWithInferredContext<(ins "mlir::Type":$type,
                                         "const llvm::APInt &":$value), [{

@erichkeane
Copy link
Collaborator Author

I'm not terribly sure of the implications of this patch, but figured I'd get one up that at least lets us build.

Copy link
Contributor

@xlauko xlauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmha
Copy link
Contributor

mmha commented Apr 22, 2025

LGTM

@erichkeane erichkeane merged commit 212f14f into llvm:main Apr 22, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants