-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Documentation typo fixes #135732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tim-hoffman
wants to merge
2
commits into
llvm:main
Choose a base branch
from
tim-hoffman:th/typos-2025Apr14
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Documentation typo fixes #135732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-mlir-core Author: Timothy Hoffman (tim-hoffman) ChangesFull diff: https://github.com/llvm/llvm-project/pull/135732.diff 2 Files Affected:
diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index ecfa5248b7559..ae1b1048d52fa 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -231,7 +231,7 @@ class TypeConverter {
}
/// Register a conversion function for attributes within types. Type
- /// converters may call this function in order to allow hoking into the
+ /// converters may call this function in order to allow hooking into the
/// translation of attributes that exist within types. For example, a type
/// converter for the `memref` type could use these conversions to convert
/// memory spaces or layouts in an extensible way.
diff --git a/mlir/include/mlir/Transforms/Passes.td b/mlir/include/mlir/Transforms/Passes.td
index a39ab77fc8fb3..9f2395e5afb99 100644
--- a/mlir/include/mlir/Transforms/Passes.td
+++ b/mlir/include/mlir/Transforms/Passes.td
@@ -365,8 +365,8 @@ def Mem2Reg : Pass<"mem2reg"> {
let description = [{
This pass removes loads out of and stores into a memory slot, and turns
them into direct uses of SSA values. This is done generically using the
- `PromoteAllocationOpInterface`, `PromoteOpInterface` and
- `PromoteMemOpInterface` interfaces.
+ `PromotableAllocationOpInterface`, `PromotableOpInterface` and
+ `PromotableMemOpInterface` interfaces.
This pass will attempt to compute which definitions of the content of
the memory slot reach operations that use the memory slot pointer. It
|
@llvm/pr-subscribers-mlir Author: Timothy Hoffman (tim-hoffman) ChangesFull diff: https://github.com/llvm/llvm-project/pull/135732.diff 2 Files Affected:
diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index ecfa5248b7559..ae1b1048d52fa 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -231,7 +231,7 @@ class TypeConverter {
}
/// Register a conversion function for attributes within types. Type
- /// converters may call this function in order to allow hoking into the
+ /// converters may call this function in order to allow hooking into the
/// translation of attributes that exist within types. For example, a type
/// converter for the `memref` type could use these conversions to convert
/// memory spaces or layouts in an extensible way.
diff --git a/mlir/include/mlir/Transforms/Passes.td b/mlir/include/mlir/Transforms/Passes.td
index a39ab77fc8fb3..9f2395e5afb99 100644
--- a/mlir/include/mlir/Transforms/Passes.td
+++ b/mlir/include/mlir/Transforms/Passes.td
@@ -365,8 +365,8 @@ def Mem2Reg : Pass<"mem2reg"> {
let description = [{
This pass removes loads out of and stores into a memory slot, and turns
them into direct uses of SSA values. This is done generically using the
- `PromoteAllocationOpInterface`, `PromoteOpInterface` and
- `PromoteMemOpInterface` interfaces.
+ `PromotableAllocationOpInterface`, `PromotableOpInterface` and
+ `PromotableMemOpInterface` interfaces.
This pass will attempt to compute which definitions of the content of
the memory slot reach operations that use the memory slot pointer. It
|
matthias-springer
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.