[flang] Fix Driver/do_concurrent_to_omp_cli.f90 test not to use runtime #135485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Flang invocation in `Driver/do_concurrent_to_omp_cli.f90` test to run compilation step only, to fix testing when building with `-DFLANG_INCLUDE_RUNTIME=OFF`. The test is only concerned with warning being emitted by the compiler, so there is no need to link the resulting executable.
llvmbot
added
flang:driver
flang
|
@llvm/pr-subscribers-flang-driver Author: Michał Górny (mgorny) ChangesFix Flang invocation in Full diff: https://github.com/llvm/llvm-project/pull/135485.diff 1 Files Affected:
diff --git a/flang/test/Driver/do_concurrent_to_omp_cli.f90 b/flang/test/Driver/do_concurrent_to_omp_cli.f90
index 41b7575e206af..bdb603f35639d 100644
--- a/flang/test/Driver/do_concurrent_to_omp_cli.f90
+++ b/flang/test/Driver/do_concurrent_to_omp_cli.f90
@@ -10,7 +10,7 @@
! BBC: -fdo-concurrent-to-openmp=<string>
! BBC-SAME: Try to map `do concurrent` loops to OpenMP [none|host|device]
-! RUN: %flang -fdo-concurrent-to-openmp=host %s 2>&1 \
+! RUN: %flang -c -fdo-concurrent-to-openmp=host %s 2>&1 \
! RUN: | FileCheck %s --check-prefix=OPT
! OPT: warning: OpenMP is required for lowering `do concurrent` loops to OpenMP.
|
tblah
approved these changes
Apr 14, 2025
|
Thanks! |
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…me (llvm#135485) Fix Flang invocation in `Driver/do_concurrent_to_omp_cli.f90` test to run compilation step only, to fix testing when building with `-DFLANG_INCLUDE_RUNTIME=OFF`. The test is only concerned with warning being emitted by the compiler, so there is no need to link the resulting executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Flang invocation in
Driver/do_concurrent_to_omp_cli.f90test to run compilation step only, to fix testing when building with-DFLANG_INCLUDE_RUNTIME=OFF. The test is only concerned with warning being emitted by the compiler, so there is no need to link the resulting executable.