ELF: Remove lock from MTE global relocation handling code. #135123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
|
@llvm/pr-subscribers-lld Author: Peter Collingbourne (pcc) ChangesThis lock is unnecessary because we can add the relocations to Full diff: https://github.com/llvm/llvm-project/pull/135123.diff 1 Files Affected:
diff --git a/lld/ELF/Relocations.cpp b/lld/ELF/Relocations.cpp
index 81de664fd1c23..277acb26987bc 100644
--- a/lld/ELF/Relocations.cpp
+++ b/lld/ELF/Relocations.cpp
@@ -847,9 +847,8 @@ static void addRelativeReloc(Ctx &ctx, InputSectionBase &isec,
Partition &part = isec.getPartition(ctx);
if (sym.isTagged()) {
- std::lock_guard<std::mutex> lock(ctx.relocMutex);
- part.relaDyn->addRelativeReloc(ctx.target->relativeRel, isec, offsetInSec,
- sym, addend, type, expr);
+ part.relaDyn->addRelativeReloc<shard>(ctx.target->relativeRel, isec,
+ offsetInSec, sym, addend, type, expr);
// With MTE globals, we always want to derive the address tag by `ldg`-ing
// the symbol. When we have a RELATIVE relocation though, we no longer have
// a reference to the symbol. Because of this, when we have an addend that
|
|
@llvm/pr-subscribers-lld-elf Author: Peter Collingbourne (pcc) ChangesThis lock is unnecessary because we can add the relocations to Full diff: https://github.com/llvm/llvm-project/pull/135123.diff 1 Files Affected:
diff --git a/lld/ELF/Relocations.cpp b/lld/ELF/Relocations.cpp
index 81de664fd1c23..277acb26987bc 100644
--- a/lld/ELF/Relocations.cpp
+++ b/lld/ELF/Relocations.cpp
@@ -847,9 +847,8 @@ static void addRelativeReloc(Ctx &ctx, InputSectionBase &isec,
Partition &part = isec.getPartition(ctx);
if (sym.isTagged()) {
- std::lock_guard<std::mutex> lock(ctx.relocMutex);
- part.relaDyn->addRelativeReloc(ctx.target->relativeRel, isec, offsetInSec,
- sym, addend, type, expr);
+ part.relaDyn->addRelativeReloc<shard>(ctx.target->relativeRel, isec,
+ offsetInSec, sym, addend, type, expr);
// With MTE globals, we always want to derive the address tag by `ldg`-ing
// the symbol. When we have a RELATIVE relocation though, we no longer have
// a reference to the symbol. Because of this, when we have an addend that
|
MaskRay
approved these changes
Apr 10, 2025
Created using spr 1.3.6-beta.1 [skip ci]
pcc
changed the base branch from
users/pcc/spr/main.elf-remove-lock-from-mte-global-relocation-handling-code
to
main
pcc
deleted the
users/pcc/spr/elf-remove-lock-from-mte-global-relocation-handling-code
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Apr 10, 2025
This lock is unnecessary because we can add the relocations to shards and let them be sorted later. Reviewers: smithp35, fmayer, MaskRay Reviewed By: MaskRay Pull Request: llvm/llvm-project#135123
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
This lock is unnecessary because we can add the relocations to shards and let them be sorted later. Reviewers: smithp35, fmayer, MaskRay Reviewed By: MaskRay Pull Request: llvm#135123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lock is unnecessary because we can add the relocations to
shards and let them be sorted later.