Skip to content

[JumpThreading][GVN] Copy metadata when inserting preload into preds #134403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[JumpThreading][GVN] Copy metadata when inserting preload into preds #134403

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
447ccd2
[JumpThreading] Copy metadata when inserting preload into preds
dtcxzyw Apr 4, 2025
763c584
[JumpThreading][GVN] Use `copyMetadataForLoad`
dtcxzyw Apr 17, 2025
673ab49
[JumpThreading] Add tests. NFC.
dtcxzyw Apr 18, 2025
89b09c8
[GVN][JumpThreading] Address review comments
dtcxzyw Apr 23, 2025
544f796
[GVN][JumpThreading] Try to salvage UB-implying metadata
dtcxzyw Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[JumpThreading] Copy metadata when inserting preload into preds
  • Loading branch information
@dtcxzyw
dtcxzyw committed Apr 17, 2025
commit 447ccd294b097e23a044de543de77d627e5363fa
7 changes: 7 additions & 0 deletions llvm/lib/Transforms/Scalar/JumpThreading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,6 +1410,13 @@ bool JumpThreadingPass::simplifyPartiallyRedundantLoad(LoadInst *LoadI) {
if (AATags)
NewVal->setAAMetadata(AATags);

if (auto *MD = LoadI->getMetadata(LLVMContext::MD_invariant_load))
NewVal->setMetadata(LLVMContext::MD_invariant_load, MD);
if (auto *InvGroupMD = LoadI->getMetadata(LLVMContext::MD_invariant_group))
NewVal->setMetadata(LLVMContext::MD_invariant_group, InvGroupMD);
if (auto *RangeMD = LoadI->getMetadata(LLVMContext::MD_range))
NewVal->setMetadata(LLVMContext::MD_range, RangeMD);

AvailablePreds.emplace_back(UnavailablePred, NewVal);
}

Expand Down