Skip to content

[clang] remove unused frontend flag -fretain-subst-template-type-parm-type-ast-nodes #134177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

mizvekov
Copy link
Contributor

@mizvekov mizvekov commented Apr 2, 2025

This is a follow-up to #132748, where we deferred the flag removal in order to ease transition for external users.

The plan is to merge this in the nearish future, in two weeks or so is my best guess.

…_type_ast_nodes

This is a folow-up to #132748, where we deferred the flag removal
in order to ease transition for external users.
@mizvekov mizvekov requested review from jvoung and ymand April 2, 2025 23:40
@mizvekov mizvekov self-assigned this Apr 2, 2025
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Apr 2, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 2, 2025

@llvm/pr-subscribers-clang

Author: Matheus Izvekov (mizvekov)

Changes

This is a follow-up to #132748, where we deferred the flag removal in order to ease transition for external users.

The plan is to merge this in the nearish future, in two weeks or so is my best guess.


Full diff: https://github.com/llvm/llvm-project/pull/134177.diff

2 Files Affected:

  • (modified) clang/include/clang/Basic/LangOptions.def (-1)
  • (modified) clang/include/clang/Driver/Options.td (-6)
diff --git a/clang/include/clang/Basic/LangOptions.def b/clang/include/clang/Basic/LangOptions.def
index 3879cc7942877..930c1c06d1a76 100644
--- a/clang/include/clang/Basic/LangOptions.def
+++ b/clang/include/clang/Basic/LangOptions.def
@@ -161,7 +161,6 @@ LANGOPT(Coroutines        , 1, 0, "C++20 coroutines")
 LANGOPT(CoroAlignedAllocation, 1, 0, "prefer Aligned Allocation according to P2014 Option 2")
 LANGOPT(DllExportInlines  , 1, 1, "dllexported classes dllexport inline methods")
 LANGOPT(ExperimentalLibrary, 1, 0, "enable unstable and experimental library features")
-LANGOPT(RetainSubstTemplateTypeParmTypeAstNodes, 1, 0, "retain SubstTemplateTypeParmType nodes in the AST's representation of alias template specializations")
 
 LANGOPT(PointerAuthIntrinsics, 1, 0, "pointer authentication intrinsics")
 LANGOPT(PointerAuthCalls  , 1, 0, "function pointer authentication")
diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index e69b804de63b5..f8b59d5c6e4aa 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -3508,12 +3508,6 @@ defm application_extension : BoolFOption<"application-extension",
   PosFlag<SetTrue, [], [ClangOption, CC1Option],
           "Restrict code to those available for App Extensions">,
   NegFlag<SetFalse>>;
-defm retain_subst_template_type_parm_type_ast_nodes : BoolFOption<"retain-subst-template-type-parm-type-ast-nodes",
-  LangOpts<"RetainSubstTemplateTypeParmTypeAstNodes">, DefaultFalse,
-  PosFlag<SetTrue, [], [CC1Option], "Enable">,
-  NegFlag<SetFalse, [], [], "Disable">,
-  BothFlags<[], [], " retain SubstTemplateTypeParmType nodes in the AST's representation"
-  " of alias template specializations">>;
 defm sized_deallocation : BoolFOption<"sized-deallocation",
   LangOpts<"SizedDeallocation">, Default<cpp14.KeyPath>,
   PosFlag<SetTrue, [], [], "Enable C++14 sized global deallocation functions">,

@mizvekov mizvekov changed the title [clang] remove unused frontend flag -fretain_subst_template_type_parm_type_ast_nodes [clang] remove unused frontend flag -fretain-subst-template-type-parm-type-ast-nodes Apr 2, 2025
Copy link
Contributor

@jvoung jvoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead (need to wait for 1 to 2 weeks) and thanks again for splitting!

@mizvekov mizvekov merged commit 40727bc into main Apr 14, 2025
12 of 14 checks passed
@mizvekov mizvekov deleted the users/mizvekov/clang/remove-subst-flag branch April 14, 2025 14:54
var-const pushed a commit to ldionne/llvm-project that referenced this pull request Apr 17, 2025
…-type-ast-nodes (llvm#134177)

This is a follow-up to llvm#132748, where we deferred the flag removal in
order to ease transition for external users.

The plan is to merge this in the nearish future, in two weeks or so is
my best guess.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants