[WinEH] Track changes in WinEHPrepare pass #134121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the pass would always claim to have changed IR if there is a scope-based personality function. We add some plumbing to track if there was an actual change. This should be NFC, except that we might now preserve more analysis passes.
|
Not sure what the effect is on compilation time, I just noticed that the pass would always report changes even when it did none while investigating #119959. |
aaronpuchert
requested review from
aheejin and
rnk
and removed request for
tentzen
|
Ping. Let me know if I have added the wrong reviewers. |
aheejin
reviewed
May 29, 2025
aheejin
approved these changes
May 29, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Before this change, the pass would always claim to have changed IR if there is a scope-based personality function. We add some plumbing to track if there was an actual change. This should be NFC, except that we might now preserve more analysis passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the pass would always claim to have changed IR if there is a scope-based personality function. We add some plumbing to track if there was an actual change.
This should be NFC, except that we might now preserve more analysis passes.