-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[RISCV] Fix the c_slli disassembler test (NFC) #133921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Each hex pattern now appears only once.
Can you add back the c.slli64 hint test cases I added after your original patch? |
Darn. Yes, of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/3326 Here is the relevant piece of the build log for the reference
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/5135 Here is the relevant piece of the build log for the reference
|
This change fixes the exhaustive text for the c.slli instruction so that each hex pattern now appears only once. The problem was spotted [here](llvm#133713 (comment)) by @topperc (for which, thank you).
This change fixes the exhaustive text for the c.slli instruction so that each hex pattern now appears only once. The problem was spotted here by @topperc (for which, thank you).