Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] implement recursive mutex and deadlock detection #133258

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SchrodingerZhu
Copy link
Contributor

No description provided.

@SchrodingerZhu
Copy link
Contributor Author

SchrodingerZhu commented Mar 27, 2025

Hi,

@michaelrj-google @lntue

I cannot make this work easily. We have to establish a cyclic dependency if we want to use the identifier library in fullbuild.
Is it possible to separate the thread attribute and thread implementation? Could you take a look at this when you have bandwidth.

@lntue
Copy link
Contributor

lntue commented Mar 27, 2025

Hi,

@michaelrj-google @lntue

I cannot make this work easily. We have to establish a cyclic dependency if we want to use the identifier library in fullbuild. Is it possible to separate the thread attribute and thread implementation? Could you take a look at this when you have bandwidth.

Look like ThreadAttributes and many common enums and typedefs in thread.h can be factored out to their own independent headers to be shared and avoid circular dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants