Skip to content

[MLIR][XeGPU] Extend SGMapAttr and Add ConvertLayoutOp #132425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 9, 2025
Merged

[MLIR][XeGPU] Extend SGMapAttr and Add ConvertLayoutOp #132425

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4838b52
extend sg_map from subgroup to workgroup
chencha3 Mar 21, 2025
cb26979
format code
chencha3 Mar 21, 2025
273fc40
remove changes to prefetch op
chencha3 Mar 21, 2025
504d274
refine the doc for TensorDesc
chencha3 Mar 21, 2025
596c953
update doc
chencha3 Mar 21, 2025
899439b
refine docs
chencha3 Mar 24, 2025
8636d15
refine docs
chencha3 Mar 24, 2025
0190418
refine util
chencha3 Mar 24, 2025
32f9272
refine convert_layout docs
chencha3 Mar 24, 2025
9bddeb6
drop ScopeAttr and refine 1D layout support
chencha3 Apr 1, 2025
784ab38
refine isEvenDistributed
chencha3 Apr 1, 2025
28cf69e
format code
chencha3 Apr 1, 2025
930f1ab
Merge branch 'main' into extend_sg_map
chencha3 Apr 1, 2025
9ed0f87
fix format issue
chencha3 Apr 1, 2025
3b389bf
add 1D layout examples
chencha3 Apr 1, 2025
cbd0af0
refine LayoutAttr verifier
chencha3 Apr 4, 2025
3fb4fd4
add unit test
chencha3 Apr 4, 2025
77fdfef
remove dump file
chencha3 Apr 4, 2025
2751332
fix typo
chencha3 Apr 4, 2025
2a16d11
Merge branch 'main' into extend_sg_map
chencha3 Apr 4, 2025
d281a14
fix an error after mering with main
chencha3 Apr 4, 2025
fb28ce8
new line at the end of file
chencha3 Apr 7, 2025
f464662
update doc
chencha3 Apr 8, 2025
eea3c35
Merge branch 'main' into extend_sg_map
chencha3 Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refine isEvenDistributed
  • Loading branch information
@chencha3
chencha3 committed Apr 1, 2025
commit 784ab38e3a0dc4fd6288375eccba66c9b8db58b4
13 changes: 8 additions & 5 deletions mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,17 @@ isArgShapesValid(TensorDescType tdescTy, VectorType valueTy,

static bool isEvenDistributed(llvm::ArrayRef<int64_t> shape,
xegpu::LayoutAttr attr) {
assert(attr && "workgroup map attribute is missing.");
assert(attr && "Layout attribute is missing.");
llvm::SmallVector<int32_t> defaults(shape.size(), 1);
llvm::ArrayRef<int32_t> layout, data;
if (attr.getSgLayout()) {
data = attr.getSgData().asArrayRef();
layout = attr.getSgLayout().asArrayRef();
if (auto sg_layout = attr.getSgLayout()) {
layout = sg_layout.asArrayRef();
auto sg_data = attr.getSgData();
data = sg_data? sg_data.asArrayRef(): defaults;
} else {
data = attr.getLaneData().asArrayRef();
layout = attr.getLaneLayout().asArrayRef();
auto lane_data = attr.getLaneData();
data = lane_data? lane_data.asArrayRef(): defaults;
}
for (auto [s, d, l] : llvm::zip_equal(shape, data, layout)) {
// check s % (d * l) != 0
Expand Down
Loading