Skip to content

[lldb] Ignore registers that the debugserver fails to read #132122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

[lldb] Ignore registers that the debugserver fails to read #132122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lldb/packages/Python/lldbsuite/test/lldbreverse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,10 @@ def capture_snapshot(self):
for index in sorted(self.general_purpose_register_info.keys()):
reply = self.pass_through(f"p{index:x};thread:{thread_id:x};")
if reply == "" or reply[0] == "E":
raise ValueError("Can't read register")
# Mac debugserver tells us about registers that it won't let
# us actually read. Ignore those registers.
self.logger.debug(f"Failed to read register {index:x}")
continue
registers[index] = reply
thread_snapshot = ThreadSnapshot(thread_id, registers)
thread_sp = self.get_register(
Expand Down
8 changes: 0 additions & 8 deletions lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,11 @@
class TestReverseContinueBreakpoints(ReverseTestBase):
@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue(self):
self.reverse_continue_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_async(self):
self.reverse_continue_internal(async_mode=True)

Expand Down Expand Up @@ -47,13 +45,11 @@ def reverse_continue_internal(self, async_mode):

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_breakpoint(self):
self.reverse_continue_breakpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_breakpoint_async(self):
self.reverse_continue_breakpoint_internal(async_mode=True)

Expand All @@ -72,13 +68,11 @@ def reverse_continue_breakpoint_internal(self, async_mode):

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_skip_breakpoint(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_skip_breakpoint_async(self):
self.reverse_continue_skip_breakpoint_internal(async_mode=True)

Expand All @@ -104,13 +98,11 @@ def reverse_continue_skip_breakpoint_internal(self, async_mode):

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_continue_preserves_direction(self):
self.continue_preserves_direction_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_continue_preserves_direction_asyhc(self):
self.continue_preserves_direction_internal(async_mode=True)

Expand Down
4 changes: 0 additions & 4 deletions lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,11 @@
class TestReverseContinueWatchpoints(ReverseTestBase):
@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_watchpoint(self):
self.reverse_continue_watchpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_watchpoint_async(self):
self.reverse_continue_watchpoint_internal(async_mode=True)

Expand Down Expand Up @@ -63,13 +61,11 @@ def reverse_continue_watchpoint_internal(self, async_mode):

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_skip_watchpoint(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=False)

@skipIfRemote
@skipIf(macos_version=["<", "15.0"])
@skipIf(oslist=lldbplatformutil.getDarwinOSTriples(), archs=["x86_64"])
def test_reverse_continue_skip_watchpoint_async(self):
self.reverse_continue_skip_watchpoint_internal(async_mode=True)

Expand Down