Skip to content

[Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes #132116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 2, 2025
Merged

[Clang] add emit -Wignored-base-class-qualifiers diagnostic for cv-qualified base classes #132116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4947bb5
Add Ignored CV Qualifiers
lyledean1 Mar 19, 2025
4c932ce
remove build
lyledean1 Mar 19, 2025
1d8b89d
Update ReleaseNotes.rst
lyledean1 Mar 19, 2025
01e74d4
Update to base-class-qualifiers name
lyledean1 Mar 20, 2025
925c19e
Update to base-class-qualifiers name
lyledean1 Mar 20, 2025
97f49f9
Update to base-class-qualifiers name
lyledean1 Mar 20, 2025
445019b
Remove toadd comment
lyledean1 Mar 20, 2025
30a2ab8
Merge branch 'main' into add-ignored-cv-qualifiers
lyledean1 Mar 28, 2025
0675b4b
Update clang/docs/ReleaseNotes.rst
lyledean1 Mar 31, 2025
5efd8b2
Update clang/include/clang/Basic/DiagnosticGroups.td
lyledean1 Mar 31, 2025
bd475a5
Update warn base type qualifier tests
lyledean1 Mar 31, 2025
d3d3a91
Merge branch 'main' into add-ignored-cv-qualifiers
lyledean1 Apr 1, 2025
36014e2
Update ReleaseNotes.rst
lyledean1 Apr 1, 2025
0d7741a
Update ReleaseNotes.rst
lyledean1 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,8 @@ Improvements to Clang's diagnostics

Fixes #GH61635

- Split diagnosing base class qualifiers from the ``-Wignored-Qualifiers`` diagnostic group into a new ``-Wignored-base-class-qualifiers`` diagnostic group (which is grouped under ``-Wignored-qualifiers``). Fixes #GH131935.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "is grouped under" relationship is the wrong way around. Should it be "controls"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the wording is sufficient. No need to change IMO.


Improvements to Clang's time-trace
----------------------------------

Expand Down
1 change: 1 addition & 0 deletions clang/include/clang/Basic/DiagnosticGroups.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,7 @@ def GNUImaginaryConstant : DiagGroup<"gnu-imaginary-constant">;
def IgnoredGCH : DiagGroup<"ignored-gch">;
def IgnoredReferenceQualifiers : DiagGroup<"ignored-reference-qualifiers">;
def IgnoredQualifiers : DiagGroup<"ignored-qualifiers", [IgnoredReferenceQualifiers]>;
def IgnoredBaseClassQualifiers : DiagGroup<"ignored-base-class-qualifiers", [IgnoredQualifiers]>;
def : DiagGroup<"import">;
def GNUIncludeNext : DiagGroup<"gnu-include-next">;
def IncompatibleMSStruct : DiagGroup<"incompatible-ms-struct">;
Expand Down
2 changes: 1 addition & 1 deletion clang/include/clang/Basic/DiagnosticSemaKinds.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ def warn_qual_return_type : Warning<
InGroup<IgnoredQualifiers>, DefaultIgnore;
def warn_qual_base_type : Warning<
"'%0' qualifier%s1 on base class type %2 %plural{1:has|:have}1 no effect">,
InGroup<IgnoredQualifiers>, DefaultIgnore;
InGroup<IgnoredBaseClassQualifiers>, DefaultIgnore;

def warn_deprecated_redundant_constexpr_static_def : Warning<
"out-of-line definition of constexpr static data member is redundant "
Expand Down
4 changes: 3 additions & 1 deletion clang/test/SemaCXX/warn-base-type-qualifiers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
// RUN: %clang_cc1 %s -std=c++11 -Wignored-qualifiers -verify
// RUN: %clang_cc1 %s -std=c++11 -Wignored-base-class-qualifiers -verify
// RUN: %clang_cc1 %s -std=c++11 -Wno-ignored-qualifiers -verify=good
// good-no-diagnostics

template <typename T> struct add_const {
using type = const T;
Expand Down