Skip to content

[lld][AArch64][Build Attributes] Add support for converting AArch64 Build Attributes to GNU Properties #131990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 89 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
f98c952
[lld][AArch64][Build Attributes] Add support for converting AArch64 B…
sivan-shani Mar 18, 2025
d4299e9
fix formatting
sivan-shani Mar 19, 2025
783dbf9
remove stand alone condition out of braces of prevoius condition
sivan-shani Mar 19, 2025
5dfca32
formatting
sivan-shani Mar 19, 2025
8b6377a
formatting
sivan-shani Mar 19, 2025
9d81bc0
formatting
sivan-shani Mar 19, 2025
9c8f950
format
sivan-shani Mar 19, 2025
94bebe0
format
sivan-shani Mar 19, 2025
e73a6bd
fix: readig symbol table should be done once per file, not per symbol…
sivan-shani Mar 19, 2025
60a5eea
remove memory header
sivan-shani Mar 20, 2025
9052abf
undo unrealted formatting
sivan-shani Mar 20, 2025
52869a1
remove unused variable
sivan-shani Mar 20, 2025
534e55e
clarify what is being sanitized in comments
sivan-shani Mar 20, 2025
02a1fa7
change SmallVector to SmallVectorImpl
sivan-shani Mar 20, 2025
ec89018
undo unrelated formatting
sivan-shani Mar 20, 2025
7292c36
fix formating fail
sivan-shani Mar 20, 2025
d026726
use instead of asigning auto f =(*this)
sivan-shani Mar 20, 2025
6709e9a
pass InputSection by reference
sivan-shani Mar 20, 2025
04e2a16
remove unnecessery headers
sivan-shani Mar 20, 2025
eb2abbc
err on unknown tags for non-optional subsection
sivan-shani Mar 20, 2025
eb84c8c
use vector.empty() instead of 0 == vector.size()
sivan-shani Mar 20, 2025
be821a5
remove warnig on empty pauth subsection
sivan-shani Mar 20, 2025
f9a0fcb
enum instead of numbers
sivan-shani Mar 20, 2025
ab6dc73
simplify: use struct to hold attributes instead of needlesly over-com…
sivan-shani Mar 20, 2025
8a21905
remove merging
sivan-shani Mar 20, 2025
fd365cb
check for gnu properties section in a separate loop before the main loop
sivan-shani Mar 20, 2025
024847d
fix asignment to wrong values
sivan-shani Mar 20, 2025
f9d7aa8
scheme --> schema
sivan-shani Mar 20, 2025
7903817
use value_or() for optionals
sivan-shani Mar 20, 2025
f225428
warn when both gnu properties and aarch64 build attributes exist
sivan-shani Mar 20, 2025
0e643e5
add test files
sivan-shani Mar 20, 2025
f187b20
remove required from test files in AArch64 folder
sivan-shani Mar 20, 2025
81a86d8
add test files for drop-in aarch64 BA replacement for gnu properties
sivan-shani Apr 1, 2025
592100f
change test files names
sivan-shani Apr 1, 2025
fe23b71
remove now unused variables
sivan-shani Apr 2, 2025
dceec93
change varibles from std::optional to unsigned
sivan-shani Apr 2, 2025
de3e43e
remove unused bool
sivan-shani Apr 2, 2025
72e725a
comments should have capital letters and full stops
sivan-shani Apr 2, 2025
902f9ef
create InputSection once outside if/else
sivan-shani Apr 2, 2025
2df0fcb
remove warning when both aarch64 BA and gno properties present + rela…
sivan-shani Apr 2, 2025
ecd2c51
remove part of tests which are irelevant for testing aarch64 ba
sivan-shani Apr 2, 2025
d439930
fix file name
sivan-shani Apr 2, 2025
22c6478
remove unused func getBuildAttributesSection
sivan-shani Apr 3, 2025
3321d46
remove test file for testing errs and warns
sivan-shani Apr 3, 2025
17dbb95
fix endianess
sivan-shani Apr 3, 2025
ed7b5e6
format
sivan-shani Apr 3, 2025
f0eb74d
restore formatting
sivan-shani Apr 3, 2025
6a541b8
remove unused function arguments
sivan-shani Apr 4, 2025
4620091
add break to loop when section found
sivan-shani Apr 4, 2025
c8637a0
refactor by using lambda
sivan-shani Apr 4, 2025
1470bdf
format
sivan-shani Apr 4, 2025
98dc05f
remove unused include, s/dispatcher/loader/
sivan-shani Apr 4, 2025
57d7ff9
do not wrtie pauth data when both values are 0
sivan-shani Apr 4, 2025
ddb1b3e
consolidate test files
sivan-shani Apr 4, 2025
debcd30
check gnu properties content
sivan-shani Apr 8, 2025
deaf7de
add test file when both GNU properties and BA present, but GP has no …
sivan-shani Apr 8, 2025
88359f4
add test file for melformed object file
sivan-shani Apr 8, 2025
64a45ed
change struct name
sivan-shani Apr 10, 2025
8873a15
handle GNU properties and build attributes after loop
sivan-shani Apr 11, 2025
9e70cbe
delete commented lines
sivan-shani Apr 11, 2025
bbb33fe
only serialize, reduce message size
sivan-shani Apr 11, 2025
711ea6f
comments
sivan-shani Apr 11, 2025
b46b466
revert unintended change in comment
sivan-shani Apr 11, 2025
24f4b80
format
sivan-shani Apr 11, 2025
8e27785
unsigned -> uint64_t
sivan-shani Apr 14, 2025
da33de6
change to uint32_t andFeatures = 0;
sivan-shani Apr 14, 2025
5cb1940
use lambda for getting attributes values
sivan-shani Apr 14, 2025
572e5f4
move reading .note.gnu.property to the parse loop
sivan-shani Apr 14, 2025
31214b8
use split-file for testing
sivan-shani Apr 14, 2025
7d2d795
move AArch64 related code to AArch64.h
sivan-shani Apr 14, 2025
b2803a3
restore white space
sivan-shani Apr 14, 2025
cb49f85
remove {} and fix typo in comments
sivan-shani Apr 14, 2025
dd89ea1
format
sivan-shani Apr 14, 2025
93f21f2
remove empty line
sivan-shani Apr 14, 2025
e40609a
revert std::string to StringRef, change already been merged
sivan-shani Apr 14, 2025
3f5b14c
typo and format
sivan-shani Apr 15, 2025
5013203
move AArch64 specific code to llvm/include/llvm/Support/AArch64Attrib…
sivan-shani Apr 16, 2025
9738781
add check before executing handleAArch64BAAndGnuProperties
sivan-shani Apr 16, 2025
45f7246
fix typo in file name
sivan-shani Apr 16, 2025
d802fcc
remove redundant tests, consolidate some tests files
sivan-shani Apr 16, 2025
ae1a032
move functions back to original location in file, add forward declara…
sivan-shani Apr 16, 2025
b5c882e
remove dead code
sivan-shani Apr 16, 2025
54fe275
move code back to prev lcation
sivan-shani Apr 16, 2025
afca83d
remove unnecessery include
sivan-shani Apr 16, 2025
20760a9
change test file from using yaml to using .section notations
sivan-shani Apr 17, 2025
8b1e002
change ErrAlways to Err
sivan-shani Apr 17, 2025
37a3aec
change test files comments to follow lld convention
sivan-shani Apr 17, 2025
da6ddb2
remove unneeded default ctor
sivan-shani Apr 22, 2025
b3e62ec
arrange forward declarations
sivan-shani Apr 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert unintended change in comment
  • Loading branch information
sivan-shani committed Apr 11, 2025
commit b46b466ac94fded722d703b1fc7c60af077f8940
2 changes: 1 addition & 1 deletion lld/ELF/InputFiles.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1910,7 +1910,7 @@ BitcodeFile::BitcodeFile(Ctx &ctx, MemoryBufferRef mb, StringRef archiveName,

// ThinLTO assumes that all MemoryBufferRefs given to it have a unique
// name. If two archives define two members with the same name, this
// causes a mismatch which result in only one of the objects being taken
// causes a collision which result in only one of the objects being taken
// into consideration at LTO time (which very likely causes undefined
// symbols later in the link stage). So we append file offset to make
// filename unique.
Expand Down
Loading