[Libc] Turn implicit to explicit conversion #130615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a build issue on the AMDGPU libc bot after llvm#126846 landed that introduced a warning.
|
@llvm/pr-subscribers-libc Author: Jan Patrick Lehr (jplehr) ChangesThis fixes a build issue on the AMDGPU libc bot after #126846 landed that introduced a warning. Full diff: https://github.com/llvm/llvm-project/pull/130615.diff 1 Files Affected:
diff --git a/libc/src/__support/high_precision_decimal.h b/libc/src/__support/high_precision_decimal.h
index 922dce484aa6b..d5bf179e80f83 100644
--- a/libc/src/__support/high_precision_decimal.h
+++ b/libc/src/__support/high_precision_decimal.h
@@ -401,7 +401,7 @@ class HighPrecisionDecimal {
this->right_shift(MAX_SHIFT_AMOUNT);
shift_amount += MAX_SHIFT_AMOUNT;
}
- this->right_shift(-shift_amount);
+ this->right_shift(-static_cast<uint32_t>(shift_amount));
}
}
|
jhuber6
reviewed
Mar 10, 2025
lntue
approved these changes
Mar 10, 2025
VishMCW
pushed a commit
to VishMCW/llvm-project
that referenced
this pull request
Mar 18, 2025
This fixes a build issue on the AMDGPU libc bot after llvm#126846 landed that introduced a warning. --------- Co-authored-by: Joseph Huber <huberjn@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build issue on the AMDGPU libc bot after #126846 landed that introduced a warning.