Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AMDGPU] Implement vop3p complex pattern optmization for gisel #130234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMDGPU] Implement vop3p complex pattern optmization for gisel #130234
Changes from 10 commits
556f7ff
58464a3
25f7db0
daae1ae
afa6448
04a5d4c
2e587f5
c6c4b3e
a289297
dd106c7
6378180
b0feaff
53370d8
3f178d2
09abc3d
79b8992
136da47
61b4df7
97e6742
d79ac03
fc7c927
9f3a54f
bc51bf4
cafa3d1
a5c5017
47840d7
6fe4147
3b7f377
d7de92f
45ed994
2f83470
d651640
a792c1d
9ac58f9
0d59649
8390425
276e41b
1cb1651
c2eeedd
dc65247
6cd21e6
ee28947
797055d
e544665
0eac2e9
e328d7a
c1680f3
d9dc316
223dc11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you can directly use
Op1->isIdenticalTo(*Op2)
for all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shiltian , direct use of
isIdenticalTo
will differentiate use/def of register and subreg.For example although 2 of them are same virtual register, it will return false if one of them is defined by instruction, one of them is used by instruction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ignoring subregister uses, but you shouldn't encounter them either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arsenm , to be honest I'm not sure about the subreg. From the isIdenticalTo function, this is comparing SubReg_TargetFlags member of MachineOperand class.
While in AMD backend 's TargetOperandFlags enumeration it seems more like address related I guess.
Should I incorporate the subreg comparison?? can you explain what SubReg_TargetFlags is used for in AMD backend??
Thanks a lot