Skip to content

Optimize the implementation of std::find_first_of to use any_of #129319 #129574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Optimize the implementation of std::find_first_of to use any_of #129319 #129574

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95937e6
Change the implementation of std::find_first_of.h to use any_of #129319
aliraeisdanaei Mar 3, 2025
2a7f951
Merge branch 'llvm:main' into optimise_find_first_of
aliraeisdanaei Apr 19, 2025
558469e
use the pedicate binary instead of equality
aliraeisdanaei Apr 19, 2025
91305de
correct the naming of the iterators (stupid mistake)
aliraeisdanaei Apr 19, 2025
68e4633
include find_if and any_of in the headers
aliraeisdanaei Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use the pedicate binary instead of equality
  • Loading branch information
@aliraeisdanaei
aliraeisdanaei committed Apr 19, 2025
commit 558469e2ac291289dd5199bff31ad9630a77a997
2 changes: 1 addition & 1 deletion libcxx/include/__algorithm/find_first_of.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 _ForwardIterator1 __find_fir
_ForwardIterator2 __last2,
_BinaryPredicate&& __pred) {
return std::find_if(first1, last1, [&](const auto& x) {
return std::any_of(first2, last2, [&](const auto& y) { return x == y; });
return std::any_of(first2, last2, [&](const auto& y) { return __pred(x, y); });
});
}

Expand Down