Skip to content

[mlir][linalg] Fix linalg.pack/unpack docs #129559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

adam-smnk
Copy link
Contributor

Adds missing relayout ops to Linalg docs tablegen.

Follow-up to #127729

Adds missing relayout ops to Linalg docs tablegen.
@llvmbot
Copy link
Member

llvmbot commented Mar 3, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-linalg

Author: Adam Siemieniuk (adam-smnk)

Changes

Adds missing relayout ops to Linalg docs tablegen.

Follow-up to #127729


Full diff: https://github.com/llvm/llvm-project/pull/129559.diff

2 Files Affected:

  • (modified) mlir/docs/Dialects/Linalg/_index.md (-1)
  • (modified) mlir/include/mlir/Dialect/Linalg/IR/LinalgDoc.td (+1)
diff --git a/mlir/docs/Dialects/Linalg/_index.md b/mlir/docs/Dialects/Linalg/_index.md
index b519e4159f186..976f0fd3c7e91 100644
--- a/mlir/docs/Dialects/Linalg/_index.md
+++ b/mlir/docs/Dialects/Linalg/_index.md
@@ -695,4 +695,3 @@ the same IR.
 ## Operations
 
 [include "Dialects/LinalgOps.md"]
-[include "Dialects/LinalgRelayoutOps.td"]
diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgDoc.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgDoc.td
index c993e614e4db8..fe08b9ec744ad 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgDoc.td
+++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgDoc.td
@@ -18,6 +18,7 @@
 
 include "mlir/Dialect/Linalg/IR/LinalgBase.td"
 include "mlir/Dialect/Linalg/IR/LinalgOps.td"
+include "mlir/Dialect/Linalg/IR/LinalgRelayoutOps.td"
 include "mlir/Dialect/Linalg/IR/LinalgStructuredOps.td"
 
 #endif // LINALG_DOC

@adam-smnk
Copy link
Contributor Author

Tested with ninja mlir-doc.
linalg.pack and linalg.unpack ops now show up in generated build/tools/mlir/docs/Dialects/LinalgOps.md.

Copy link
Contributor

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

LGTM

@adam-smnk adam-smnk merged commit e187fc0 into llvm:main Mar 4, 2025
14 checks passed
jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
Adds missing relayout ops to Linalg docs tablegen.

Follow-up to llvm#127729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants