Skip to content

[NFC] [clang] [sanitize] add autogen test for array-bounds debuginfo #128976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fmayer
Copy link
Contributor

@fmayer fmayer commented Feb 27, 2025

No description provided.

Created using spr 1.3.4
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Feb 27, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 27, 2025

@llvm/pr-subscribers-clang

Author: Florian Mayer (fmayer)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/128976.diff

1 Files Affected:

  • (added) clang/test/CodeGen/bounds-checking-debuginfo.c (+118)
diff --git a/clang/test/CodeGen/bounds-checking-debuginfo.c b/clang/test/CodeGen/bounds-checking-debuginfo.c
new file mode 100644
index 0000000000000..16802f57938e7
--- /dev/null
+++ b/clang/test/CodeGen/bounds-checking-debuginfo.c
@@ -0,0 +1,118 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5
+// RUN: %clang_cc1 -emit-llvm -fsanitize=array-bounds -fsanitize-trap=array-bounds -triple x86_64 -debug-info-kind=standalone %s -o - | FileCheck --check-prefix=CHECK-TRAP
+// RUN: %clang_cc1 -emit-llvm -fsanitize=array-bounds                              -triple x86_64 -debug-info-kind=standalone %s -o - | FileCheck --check-prefix=CHECK-NOTRAP
+
+
+int f();
+void d(double*);
+
+// CHECK-LABEL: @f1
+// CHECK-TRAP-LABEL: define dso_local double @f1(
+// CHECK-TRAP-SAME: i32 noundef [[B:%.*]], i32 noundef [[I:%.*]]) #[[ATTR0:[0-9]+]] !dbg [[DBG5:![0-9]+]] {
+// CHECK-TRAP-NEXT:  [[ENTRY:.*:]]
+// CHECK-TRAP-NEXT:    [[B_ADDR:%.*]] = alloca i32, align 4
+// CHECK-TRAP-NEXT:    [[I_ADDR:%.*]] = alloca i32, align 4
+// CHECK-TRAP-NEXT:    [[A:%.*]] = alloca [10 x double], align 16
+// CHECK-TRAP-NEXT:    store i32 [[B]], ptr [[B_ADDR]], align 4
+// CHECK-TRAP-NEXT:      #dbg_declare(ptr [[B_ADDR]], [[META12:![0-9]+]], !DIExpression(), [[META13:![0-9]+]])
+// CHECK-TRAP-NEXT:    store i32 [[I]], ptr [[I_ADDR]], align 4
+// CHECK-TRAP-NEXT:      #dbg_declare(ptr [[I_ADDR]], [[META14:![0-9]+]], !DIExpression(), [[META15:![0-9]+]])
+// CHECK-TRAP-NEXT:      #dbg_declare(ptr [[A]], [[META16:![0-9]+]], !DIExpression(), [[META20:![0-9]+]])
+// CHECK-TRAP-NEXT:    [[ARRAYDECAY:%.*]] = getelementptr inbounds [10 x double], ptr [[A]], i64 0, i64 0, !dbg [[DBG21:![0-9]+]]
+// CHECK-TRAP-NEXT:    call void @d(ptr noundef [[ARRAYDECAY]]), !dbg [[DBG22:![0-9]+]]
+// CHECK-TRAP-NEXT:    [[CALL:%.*]] = call i32 (...) @f(), !dbg [[DBG23:![0-9]+]]
+// CHECK-TRAP-NEXT:    [[TMP0:%.*]] = sext i32 [[CALL]] to i64, !dbg [[DBG24:![0-9]+]], !nosanitize [[META11:![0-9]+]]
+// CHECK-TRAP-NEXT:    [[TMP1:%.*]] = icmp ult i64 [[TMP0]], 10, !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-TRAP-NEXT:    br i1 [[TMP1]], label %[[CONT:.*]], label %[[TRAP:.*]], !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-TRAP:       [[TRAP]]:
+// CHECK-TRAP-NEXT:    call void @llvm.ubsantrap(i8 18) #[[ATTR3:[0-9]+]], !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-TRAP-NEXT:    unreachable, !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-TRAP:       [[CONT]]:
+// CHECK-TRAP-NEXT:    [[IDXPROM:%.*]] = sext i32 [[CALL]] to i64, !dbg [[DBG24]]
+// CHECK-TRAP-NEXT:    [[ARRAYIDX:%.*]] = getelementptr inbounds [10 x double], ptr [[A]], i64 0, i64 [[IDXPROM]], !dbg [[DBG24]]
+// CHECK-TRAP-NEXT:    [[TMP2:%.*]] = load double, ptr [[ARRAYIDX]], align 8, !dbg [[DBG24]]
+// CHECK-TRAP-NEXT:    ret double [[TMP2]], !dbg [[DBG25:![0-9]+]]
+//
+// CHECK-NOTRAP-LABEL: define dso_local double @f1(
+// CHECK-NOTRAP-SAME: i32 noundef [[B:%.*]], i32 noundef [[I:%.*]]) #[[ATTR0:[0-9]+]] !dbg [[DBG5:![0-9]+]] {
+// CHECK-NOTRAP-NEXT:  [[ENTRY:.*:]]
+// CHECK-NOTRAP-NEXT:    [[B_ADDR:%.*]] = alloca i32, align 4
+// CHECK-NOTRAP-NEXT:    [[I_ADDR:%.*]] = alloca i32, align 4
+// CHECK-NOTRAP-NEXT:    [[A:%.*]] = alloca [10 x double], align 16
+// CHECK-NOTRAP-NEXT:    store i32 [[B]], ptr [[B_ADDR]], align 4
+// CHECK-NOTRAP-NEXT:      #dbg_declare(ptr [[B_ADDR]], [[META12:![0-9]+]], !DIExpression(), [[META13:![0-9]+]])
+// CHECK-NOTRAP-NEXT:    store i32 [[I]], ptr [[I_ADDR]], align 4
+// CHECK-NOTRAP-NEXT:      #dbg_declare(ptr [[I_ADDR]], [[META14:![0-9]+]], !DIExpression(), [[META15:![0-9]+]])
+// CHECK-NOTRAP-NEXT:      #dbg_declare(ptr [[A]], [[META16:![0-9]+]], !DIExpression(), [[META20:![0-9]+]])
+// CHECK-NOTRAP-NEXT:    [[ARRAYDECAY:%.*]] = getelementptr inbounds [10 x double], ptr [[A]], i64 0, i64 0, !dbg [[DBG21:![0-9]+]]
+// CHECK-NOTRAP-NEXT:    call void @d(ptr noundef [[ARRAYDECAY]]), !dbg [[DBG22:![0-9]+]]
+// CHECK-NOTRAP-NEXT:    [[CALL:%.*]] = call i32 (...) @f(), !dbg [[DBG23:![0-9]+]]
+// CHECK-NOTRAP-NEXT:    [[TMP0:%.*]] = sext i32 [[CALL]] to i64, !dbg [[DBG24:![0-9]+]], !nosanitize [[META11:![0-9]+]]
+// CHECK-NOTRAP-NEXT:    [[TMP1:%.*]] = icmp ult i64 [[TMP0]], 10, !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-NOTRAP-NEXT:    br i1 [[TMP1]], label %[[CONT:.*]], label %[[HANDLER_OUT_OF_BOUNDS:.*]], !dbg [[DBG24]], !prof [[PROF25:![0-9]+]], !nosanitize [[META11]]
+// CHECK-NOTRAP:       [[HANDLER_OUT_OF_BOUNDS]]:
+// CHECK-NOTRAP-NEXT:    [[TMP2:%.*]] = zext i32 [[CALL]] to i64, !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-NOTRAP-NEXT:    call void @__ubsan_handle_out_of_bounds_abort(ptr @[[GLOB2:[0-9]+]], i64 [[TMP2]]) #[[ATTR3:[0-9]+]], !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-NOTRAP-NEXT:    unreachable, !dbg [[DBG24]], !nosanitize [[META11]]
+// CHECK-NOTRAP:       [[CONT]]:
+// CHECK-NOTRAP-NEXT:    [[IDXPROM:%.*]] = sext i32 [[CALL]] to i64, !dbg [[DBG24]]
+// CHECK-NOTRAP-NEXT:    [[ARRAYIDX:%.*]] = getelementptr inbounds [10 x double], ptr [[A]], i64 0, i64 [[IDXPROM]], !dbg [[DBG24]]
+// CHECK-NOTRAP-NEXT:    [[TMP3:%.*]] = load double, ptr [[ARRAYIDX]], align 8, !dbg [[DBG24]]
+// CHECK-NOTRAP-NEXT:    ret double [[TMP3]], !dbg [[DBG26:![0-9]+]]
+//
+double f1(int b, int i) {
+  double a[10];
+  d(a);
+  return a[f()];
+}
+
+//.
+// CHECK-TRAP: [[META0:![0-9]+]] = distinct !DICompileUnit(language: DW_LANG_C11, file: [[META1:![0-9]+]], producer: "{{.*}}clang version {{.*}}", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, splitDebugInlining: false, nameTableKind: None)
+// CHECK-TRAP: [[META1]] = !DIFile(filename: "clang/test/CodeGen/<stdin>", directory: {{.*}})
+// CHECK-TRAP: [[DBG5]] = distinct !DISubprogram(name: "f1", scope: [[META6:![0-9]+]], file: [[META6]], line: 62, type: [[META7:![0-9]+]], scopeLine: 62, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: [[META0]], retainedNodes: [[META11]])
+// CHECK-TRAP: [[META6]] = !DIFile(filename: "clang/test/CodeGen/bounds-checking-debuginfo.c", directory: {{.*}})
+// CHECK-TRAP: [[META7]] = !DISubroutineType(types: [[META8:![0-9]+]])
+// CHECK-TRAP: [[META8]] = !{[[META9:![0-9]+]], [[META10:![0-9]+]], [[META10]]}
+// CHECK-TRAP: [[META9]] = !DIBasicType(name: "double", size: 64, encoding: DW_ATE_float)
+// CHECK-TRAP: [[META10]] = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
+// CHECK-TRAP: [[META11]] = !{}
+// CHECK-TRAP: [[META12]] = !DILocalVariable(name: "b", arg: 1, scope: [[DBG5]], file: [[META6]], line: 62, type: [[META10]])
+// CHECK-TRAP: [[META13]] = !DILocation(line: 62, column: 15, scope: [[DBG5]])
+// CHECK-TRAP: [[META14]] = !DILocalVariable(name: "i", arg: 2, scope: [[DBG5]], file: [[META6]], line: 62, type: [[META10]])
+// CHECK-TRAP: [[META15]] = !DILocation(line: 62, column: 22, scope: [[DBG5]])
+// CHECK-TRAP: [[META16]] = !DILocalVariable(name: "a", scope: [[DBG5]], file: [[META6]], line: 63, type: [[META17:![0-9]+]])
+// CHECK-TRAP: [[META17]] = !DICompositeType(tag: DW_TAG_array_type, baseType: [[META9]], size: 640, elements: [[META18:![0-9]+]])
+// CHECK-TRAP: [[META18]] = !{[[META19:![0-9]+]]}
+// CHECK-TRAP: [[META19]] = !DISubrange(count: 10)
+// CHECK-TRAP: [[META20]] = !DILocation(line: 63, column: 10, scope: [[DBG5]])
+// CHECK-TRAP: [[DBG21]] = !DILocation(line: 64, column: 5, scope: [[DBG5]])
+// CHECK-TRAP: [[DBG22]] = !DILocation(line: 64, column: 3, scope: [[DBG5]])
+// CHECK-TRAP: [[DBG23]] = !DILocation(line: 65, column: 12, scope: [[DBG5]])
+// CHECK-TRAP: [[DBG24]] = !DILocation(line: 65, column: 10, scope: [[DBG5]])
+// CHECK-TRAP: [[DBG25]] = !DILocation(line: 65, column: 3, scope: [[DBG5]])
+//.
+// CHECK-NOTRAP: [[META0:![0-9]+]] = distinct !DICompileUnit(language: DW_LANG_C11, file: [[META1:![0-9]+]], producer: "{{.*}}clang version {{.*}}", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, splitDebugInlining: false, nameTableKind: None)
+// CHECK-NOTRAP: [[META1]] = !DIFile(filename: "clang/test/CodeGen/<stdin>", directory: {{.*}})
+// CHECK-NOTRAP: [[DBG5]] = distinct !DISubprogram(name: "f1", scope: [[META6:![0-9]+]], file: [[META6]], line: 62, type: [[META7:![0-9]+]], scopeLine: 62, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: [[META0]], retainedNodes: [[META11]])
+// CHECK-NOTRAP: [[META6]] = !DIFile(filename: "clang/test/CodeGen/bounds-checking-debuginfo.c", directory: {{.*}})
+// CHECK-NOTRAP: [[META7]] = !DISubroutineType(types: [[META8:![0-9]+]])
+// CHECK-NOTRAP: [[META8]] = !{[[META9:![0-9]+]], [[META10:![0-9]+]], [[META10]]}
+// CHECK-NOTRAP: [[META9]] = !DIBasicType(name: "double", size: 64, encoding: DW_ATE_float)
+// CHECK-NOTRAP: [[META10]] = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
+// CHECK-NOTRAP: [[META11]] = !{}
+// CHECK-NOTRAP: [[META12]] = !DILocalVariable(name: "b", arg: 1, scope: [[DBG5]], file: [[META6]], line: 62, type: [[META10]])
+// CHECK-NOTRAP: [[META13]] = !DILocation(line: 62, column: 15, scope: [[DBG5]])
+// CHECK-NOTRAP: [[META14]] = !DILocalVariable(name: "i", arg: 2, scope: [[DBG5]], file: [[META6]], line: 62, type: [[META10]])
+// CHECK-NOTRAP: [[META15]] = !DILocation(line: 62, column: 22, scope: [[DBG5]])
+// CHECK-NOTRAP: [[META16]] = !DILocalVariable(name: "a", scope: [[DBG5]], file: [[META6]], line: 63, type: [[META17:![0-9]+]])
+// CHECK-NOTRAP: [[META17]] = !DICompositeType(tag: DW_TAG_array_type, baseType: [[META9]], size: 640, elements: [[META18:![0-9]+]])
+// CHECK-NOTRAP: [[META18]] = !{[[META19:![0-9]+]]}
+// CHECK-NOTRAP: [[META19]] = !DISubrange(count: 10)
+// CHECK-NOTRAP: [[META20]] = !DILocation(line: 63, column: 10, scope: [[DBG5]])
+// CHECK-NOTRAP: [[DBG21]] = !DILocation(line: 64, column: 5, scope: [[DBG5]])
+// CHECK-NOTRAP: [[DBG22]] = !DILocation(line: 64, column: 3, scope: [[DBG5]])
+// CHECK-NOTRAP: [[DBG23]] = !DILocation(line: 65, column: 12, scope: [[DBG5]])
+// CHECK-NOTRAP: [[DBG24]] = !DILocation(line: 65, column: 10, scope: [[DBG5]])
+// CHECK-NOTRAP: [[PROF25]] = !{!"branch_weights", i32 1048575, i32 1}
+// CHECK-NOTRAP: [[DBG26]] = !DILocation(line: 65, column: 3, scope: [[DBG5]])
+//.

@fmayer fmayer requested a review from thurstond February 27, 2025 01:00
Created using spr 1.3.4
Created using spr 1.3.4
Created using spr 1.3.4
@fmayer fmayer merged commit db4dd33 into main Feb 27, 2025
11 checks passed
@fmayer fmayer deleted the users/fmayer/spr/nfc-clang-sanitize-add-autogen-test-for-array-bounds-debuginfo branch February 27, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants