[clang][NFC] Update isAuxBuiltinID comment #128038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Nick Sarnie (sarnex) ChangesClarify behavior of the function when the builtin is also supported on the main target. Full diff: https://github.com/llvm/llvm-project/pull/128038.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/Builtins.h b/clang/include/clang/Basic/Builtins.h
index 6d29b4315e5a7..91a03c3a51da2 100644
--- a/clang/include/clang/Basic/Builtins.h
+++ b/clang/include/clang/Basic/Builtins.h
@@ -408,7 +408,9 @@ class Context {
unsigned getRequiredVectorWidth(unsigned ID) const;
- /// Return true if builtin ID belongs to AuxTarget.
+ /// Return true if builtin ID belongs to only the AuxTarget.
+ /// Return false if builtin ID belongs to both the primary
+ /// and auxiliary target.
bool isAuxBuiltinID(unsigned ID) const {
return ID >= (Builtin::FirstTSBuiltin + NumTargetBuiltins);
}
|
erichkeane
reviewed
Feb 20, 2025
clang/include/clang/Basic/Builtins.h
Outdated
| @@ -408,7 +408,9 @@ class Context { | |||
|
|
|||
| unsigned getRequiredVectorWidth(unsigned ID) const; | |||
|
|
|||
| /// Return true if builtin ID belongs to AuxTarget. | |||
| /// Return true if builtin ID belongs to only the AuxTarget. | |||
There was a problem hiding this comment.
Perhaps, "Return true if the builtin ID belongs exclusively to the AuxTarget, and false if it belongs to both primary and aux target, or neither."
WDYT?
There was a problem hiding this comment.
sure, applied this in latest commit.
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
erichkeane
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify behavior of the function when the builtin is also supported on the main target.
Based on feedback from #126324